Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: test with more platforms #35

Closed
vicb opened this issue Sep 30, 2014 · 7 comments
Closed

Travis: test with more platforms #35

vicb opened this issue Sep 30, 2014 · 7 comments
Labels
area: build & ci Related the build and CI infrastructure of the project effort3: weeks feature Issue that requests a new feature

Comments

@vicb
Copy link
Contributor

vicb commented Sep 30, 2014

What about testing with more browsers:

  • IE,
  • Safari,
  • Firefox,
  • Chrome

I had been working on testing angular.dart on those platforms with SauceLabs, ref dart-archive/angular.dart#1288

@caitp
Copy link
Contributor

caitp commented Sep 30, 2014

Would it not make sense to bring mobile browsers in early for the benchmarks? (no pressure)

@EisenbergEffect
Copy link

I would certainly vote for that. I think we've been emphasizing mobile to
the community. So, if we want to keep ourselves honest, we should probably
start testing that up front.

On Tue, Sep 30, 2014 at 9:34 AM, Caitlin Potter notifications@github.com
wrote:

Would it not make sense to bring mobile browsers in early for the
benchmarks? (no pressure)


Reply to this email directly or view it on GitHub
#35 (comment).

Rob Eisenberg,
President - Blue Spire
www.durandaljs.com

@tbosch
Copy link
Contributor

tbosch commented Oct 1, 2014

Yes, we should add more browsers.
But probably not until AngularJS 1.3 and AngularDart 1.0 are out to not
cause more Travis digestion problems, as we only have a limited amount of
granted vms...

On Tuesday, September 30, 2014, Rob Eisenberg notifications@github.com
wrote:

I would certainly vote for that. I think we've been emphasizing mobile to
the community. So, if we want to keep ourselves honest, we should probably
start testing that up front.

On Tue, Sep 30, 2014 at 9:34 AM, Caitlin Potter <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

Would it not make sense to bring mobile browsers in early for the
benchmarks? (no pressure)


Reply to this email directly or view it on GitHub
#35 (comment).

Rob Eisenberg,
President - Blue Spire
www.durandaljs.com


Reply to this email directly or view it on GitHub
#35 (comment).

@naomiblack naomiblack added this to the TBD milestone Oct 14, 2014
@ericwj
Copy link

ericwj commented May 17, 2015

Even if you will test other browsers later, it'd be nice to get some issues out of the way perhaps - simple things such as vendor prefixes?

For example would you like me to patch elementMatches in browser_adapter.ts? It calls Element.matches(string) which is still prefixed as msMatchesSelector in IE and Edge and that breaks my template that uses <content select="[ding]"/> in those browsers and everything else comes down as a result as well.

@mhevery mhevery added area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature comp: code-generation effort3: weeks and removed area: build & ci Related the build and CI infrastructure of the project #development_infrastructure labels May 29, 2015
@mhevery mhevery removed this from the TBD milestone Jun 3, 2015
@pkozlowski-opensource
Copy link
Member

We've got a PR for this already: #2347

@mhevery
Copy link
Contributor

mhevery commented Aug 24, 2015

@Mlaval is already working on this.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: build & ci Related the build and CI infrastructure of the project effort3: weeks feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

9 participants