fix(core): don't re-invoke pure pipes that throw and arguments are the same #35827

pkozlowski-opensource · 2020-03-03T13:26:43Z

No description provided.

…e same Pure pipes are not invoked again until their arguments are modified. The same rule should apply to pure pipes that throw an exception. This fix ensures that a pure pipe is not re-invoked if it throws an exception and arguments are not changed.

kara

LGTM

kara · 2020-03-10T18:37:16Z

presubmit

…e same (#35827) Pure pipes are not invoked again until their arguments are modified. The same rule should apply to pure pipes that throw an exception. This fix ensures that a pure pipe is not re-invoked if it throws an exception and arguments are not changed. PR Close #35827

angular-automatic-lock-bot · 2020-04-11T16:06:09Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Mar 3, 2020

pkozlowski-opensource force-pushed the pure_fn_exploration branch from 428b25b to 8acdf42 Compare March 3, 2020 13:48

mhevery mentioned this pull request Mar 3, 2020

Fix FW-1860: fix(core): don't re-invoke pure pipe if error thrown #35434

Closed

14 tasks

atscott added the area: core Issues related to the framework runtime label Mar 3, 2020

ngbot bot added this to the needsTriage milestone Mar 3, 2020

pkozlowski-opensource force-pushed the pure_fn_exploration branch 2 times, most recently from 2e206ee to 4e33536 Compare March 5, 2020 13:05

pkozlowski-opensource force-pushed the pure_fn_exploration branch from 4e33536 to ba0cd92 Compare March 5, 2020 14:30

pkozlowski-opensource changed the title ~~fix(core): wip~~ fix(core): don't re-invoke pure pipes that throw and arguments are the same Mar 5, 2020

pkozlowski-opensource marked this pull request as ready for review March 5, 2020 14:42

pullapprove bot requested a review from kara March 5, 2020 14:42

pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 5, 2020

mhevery approved these changes Mar 5, 2020

View reviewed changes

pkozlowski-opensource requested review from mhevery and removed request for kara March 10, 2020 10:56

pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 10, 2020

kara approved these changes Mar 10, 2020

View reviewed changes

kara added the action: presubmit The PR is in need of a google3 presubmit label Mar 10, 2020

kara removed the request for review from mhevery March 10, 2020 22:46

kara removed the action: presubmit The PR is in need of a google3 presubmit label Mar 10, 2020

matsko closed this in 19cfaf7 Mar 11, 2020

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): don't re-invoke pure pipes that throw and arguments are the same #35827

fix(core): don't re-invoke pure pipes that throw and arguments are the same #35827

pkozlowski-opensource commented Mar 3, 2020

kara left a comment

kara commented Mar 10, 2020

angular-automatic-lock-bot bot commented Apr 11, 2020

fix(core): don't re-invoke pure pipes that throw and arguments are the same #35827

fix(core): don't re-invoke pure pipes that throw and arguments are the same #35827

Conversation

pkozlowski-opensource commented Mar 3, 2020

kara left a comment

Choose a reason for hiding this comment

kara commented Mar 10, 2020

angular-automatic-lock-bot bot commented Apr 11, 2020