Alert in built-in directives guide seems to be placed irrelevant #38525
Assignees
Labels
freq1: low
P4
A relatively minor issue that is not relevant to core functions
state: confirmed
type: bug/fix
Milestone
Comments
|
It is a valid statement, but I agree that perhaps its position makes it look particularly associated with the ngFor directive rather than Angular's common directives in general. @kapunahelewong / @aikidave - thoughts? |
|
Should we maybe put it in the intro to the document? If I understand, it applies to all types of built-in directives, right? |
|
Yes it applies to all the built-ins. I guess the point is that even though they are built-in they could have been built by 3rd parties. |
jelbourn
added
P4
josephperrott
added a commit
to josephperrott/angular
that referenced
this issue
May 21, 2021
…l place Moving the helpful alert expressing that built-in directives use public APIs to be under the heading about built-in directives generally makes the content in the alert more related to its surroundings than its previous locaion within the ng-for section. Closes angular#38525
josephperrott
added a commit
to josephperrott/angular
that referenced
this issue
May 21, 2021
…l place Moving the helpful alert expressing that built-in directives use public APIs to be under the heading about built-in directives generally makes the content in the alert more related to its surroundings than its previous location within the ng-for section. Closes angular#38525
josephperrott
added a commit
to josephperrott/angular
that referenced
this issue
May 21, 2021
…l place Moving the helpful alert expressing that built-in directives use public APIs to be under the heading about built-in directives generally makes the content in the alert more related to its surroundings than its previous location within the ng-for section. Closes angular#38525
zarend
pushed a commit
that referenced
this issue
May 21, 2021
…l place (#42226) Moving the helpful alert expressing that built-in directives use public APIs to be under the heading about built-in directives generally makes the content in the alert more related to its surroundings than its previous location within the ng-for section. Closes #38525 PR Close #42226
iRealNirmal
pushed a commit
to iRealNirmal/angular
that referenced
this issue
Jun 4, 2021
…l place (angular#42226) Moving the helpful alert expressing that built-in directives use public APIs to be under the heading about built-in directives generally makes the content in the alert more related to its surroundings than its previous location within the ng-for section. Closes angular#38525 PR Close angular#42226
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
📚 Docs or angular.io bug report
Description
It seems that the alert about the use of access on public and private APIs from built-in directives is not related in the `NgFor` section. If it is, something that is not clear to me, maybe the content should be modified to convey a more clear meaning.🔬 Minimal Reproduction
What's the affected URL?**
https://angular.io/guide/built-in-directives#ngforReproduction Steps**
Expected vs Actual Behavior**
📷Screenshot
🔥 Exception or Error
🌍 Your Environment
Browser info
Anything else relevant?
The text was updated successfully, but these errors were encountered: