fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap. #3970

jteplitz · 2015-09-03T00:47:14Z

yjbanov · 2015-09-03T00:53:21Z

modules/angular2/test/web_workers/shared/mock_event_emitter.dart

@@ -5,17 +5,16 @@ import 'dart:async';
 import "package:angular2/src/core/facade/async.dart";

 class MockEventEmitter extends EventEmitter {
-  List<Function> _nextFns = new List();
+  StreamController<String> controller = new StreamController.broadcast();


Since the controller is assigned once, it can be made final, and as a bonus, you can also omit the LHS type annotation, since it is inferred from the RHS.

…can bootstrap.

angular-automatic-lock-bot · 2019-09-07T03:20:45Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jteplitz added action: review The PR is still awaiting reviews from at least one requested reviewer comp: core/webworker labels Sep 3, 2015

jteplitz assigned yjbanov Sep 3, 2015

googlebot added the cla: yes label Sep 3, 2015

yjbanov reviewed Sep 3, 2015
View reviewed changes

yjbanov added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 3, 2015

yjbanov assigned jteplitz and unassigned yjbanov Sep 3, 2015

jteplitz force-pushed the server-message-bus branch 2 times, most recently from 9f32a77 to 7830aa7 Compare September 3, 2015 18:32

jteplitz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 3, 2015

fix(WebWorker): Fix Todo Server demo and add test to ensure the demo …

8579997

…can bootstrap.

jteplitz force-pushed the server-message-bus branch from 7830aa7 to 8579997 Compare September 3, 2015 18:50

jteplitz closed this in 696edde Sep 3, 2015

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap. #3970

fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap. #3970

jteplitz commented Sep 3, 2015

yjbanov Sep 3, 2015

angular-automatic-lock-bot bot commented Sep 7, 2019

fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap. #3970

fix(WebWorker): Fix Todo Server demo and add test to ensure the demo can bootstrap. #3970

Conversation

jteplitz commented Sep 3, 2015

yjbanov Sep 3, 2015

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 7, 2019