Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update stackblitz code version by fixing name of <live-example> #40284

Closed

Conversation

ShubhankarKG
Copy link

The previous life example had the name "...-v0". This caused the products.ts in the tutorial to not have an id field.
Later on, during navigation, readers had to deduce that they need to add an id field manually.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #40280

What is the new behavior?

The <live-example> points to the new products.ts file that has id for each product.

Does this PR introduce a breaking change?

  • Yes
  • No

The previous life example had the name "...-v0". This caused the products.ts in the tutorial to not have an id field.
Later on, during navigation, readers had to deduce that they need to add an id field manually.
@google-cla
Copy link

google-cla bot commented Dec 31, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 31, 2020
@ngbot ngbot bot added this to the Backlog milestone Dec 31, 2020
@ShubhankarKG
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added the cla: yes label Dec 31, 2020
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview comp: docs target: patch This PR is targeted for the next patch release labels Dec 31, 2020
@mary-poppins
Copy link

You can preview c883e08 at https://pr40284-c883e08.ngbuilds.io/.

@pullapprove pullapprove bot removed the comp: docs label Dec 31, 2020
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is quite right to change this link to point to the "final" application, since then there is nothing for people to do as they are following along with the tutorial.

Instead I think we should update the v0 example to contain what is needed at: https://github.com/angular/angular/tree/master/aio/content/examples/getting-started-v0

@petebacondarwin petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 31, 2020
The getting-started-v0 had products.ts that did not have id fields.
This can cause an issue in the navigation part. This commit adds an id field to all products.
@ShubhankarKG
Copy link
Author

Sorry about that, did not realize I had linked the final application. 😅

@mary-poppins
Copy link

You can preview 3ed4567 at https://pr40284-3ed4567.ngbuilds.io/.

Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, pending @petebacondarwin provides final approval here.

Reviewed-for: global-docs-approvers

@aikithoughts
Copy link
Contributor

Is this change overlapping with PR 40197?

@ShubhankarKG
Copy link
Author

Yes, looks like it. This change is a subset of #40197.

@petebacondarwin
Copy link
Member

@ShubhankarKG - thanks for working on this PR but since it is a subset of #40197, which is about to be merged, I am going to go ahead and close this PR.

@ShubhankarKG
Copy link
Author

Sure

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants