New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update stackblitz code version by fixing name of <live-example> #40284
docs: update stackblitz code version by fixing name of <live-example> #40284
Conversation
The previous life example had the name "...-v0". This caused the products.ts in the tutorial to not have an id field. Later on, during navigation, readers had to deduce that they need to add an id field manually.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
You can preview c883e08 at https://pr40284-c883e08.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is quite right to change this link to point to the "final" application, since then there is nothing for people to do as they are following along with the tutorial.
Instead I think we should update the v0
example to contain what is needed at: https://github.com/angular/angular/tree/master/aio/content/examples/getting-started-v0
The getting-started-v0 had products.ts that did not have id fields. This can cause an issue in the navigation part. This commit adds an id field to all products.
Sorry about that, did not realize I had linked the final application. 😅 |
You can preview 3ed4567 at https://pr40284-3ed4567.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, pending @petebacondarwin provides final approval here.
Reviewed-for: global-docs-approvers
Is this change overlapping with PR 40197? |
Yes, looks like it. This change is a subset of #40197. |
@ShubhankarKG - thanks for working on this PR but since it is a subset of #40197, which is about to be merged, I am going to go ahead and close this PR. |
Sure |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The previous life example had the name "...-v0". This caused the products.ts in the tutorial to not have an id field.
Later on, during navigation, readers had to deduce that they need to add an id field manually.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #40280
What is the new behavior?
The
<live-example>
points to the newproducts.ts
file that hasid
for each product.Does this PR introduce a breaking change?