Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(compiler): Token#toString returns null for TokenType.OPERATOR #4049

Closed
kegluneq opened this issue Sep 8, 2015 · 1 comment · Fixed by #4050
Closed

bug(compiler): Token#toString returns null for TokenType.OPERATOR #4049

kegluneq opened this issue Sep 8, 2015 · 1 comment · Fixed by #4050
Assignees
@kegluneq
Labels
effort1: hours type: bug/fix
Milestone
alpha-38

Comments

@kegluneq
Copy link

kegluneq commented Sep 8, 2015

Token#toString is missing a case for TokenType.OPERATOR, so it returns null when called for a token of that type. This causes Dart string interpolation to fail, for example here if it attempts to report an unexpected OPERATOR token.
@kegluneq kegluneq added this to the alpha-38 milestone Sep 8, 2015
@kegluneq kegluneq assigned kegluneq and unassigned tbosch Sep 8, 2015
kegluneq pushed a commit to kegluneq/angular that referenced this issue Sep 8, 2015
fix(compiler): Implement Token#toString for Operator
513db8f 
Include a case for `TokenType.Operator`.

Closes angular#4049
@kegluneq kegluneq mentioned this issue Sep 8, 2015
Merged
kegluneq pushed a commit to kegluneq/angular that referenced this issue Sep 8, 2015
fix(compiler): Implement Token#toString for Operator
3b9c086 
Include a case for `TokenType.Operator`.

Closes angular#4049
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kegluneq kegluneq

Labels
effort1: hours type: bug/fix
Projects
None yet
Milestone
alpha-38
Development

Successfully merging a pull request may close this issue.

fix(compiler): Implement Token#toString for Operator kegluneq/angular
2 participants
@kegluneq @tbosch