Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): allow binding to autocomplete property on select and textarea elements #40928

Closed
wants to merge 1 commit into from
Closed

fix(compiler): allow binding to autocomplete property on select and textarea elements #40928

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Updates the schema to allow binding to the autocomplete property of a textarea or select.

Fixes #39490.

@crisbeto
fix(compiler): allow binding to autocomplete property on select and t…
4b4580c 
…extarea elements

Updates the schema to allow binding to the `autocomplete` property of a `textarea` or `select`.

Fixes angular#39490.
@crisbeto crisbeto added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 20, 2021
@google-cla google-cla bot added the cla: yes label Feb 20, 2021
@crisbeto crisbeto changed the title fix(compiler): allow binding to autocomplete property on select and t… fix(compiler): allow binding to autocomplete property on select and textarea elements Feb 20, 2021
jelbourn
jelbourn approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@atscott atscott added the area: compiler Issues related to `ngc`, Angular's template compiler label Feb 22, 2021
@ngbot ngbot bot added this to the Backlog milestone Feb 22, 2021
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 27, 2021
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir
Copy link
Contributor

@crisbeto FYI presubmits are successful for the changes in this PR. This PR should be ready for merge once there is a final approval from language-service group (cc @kyliau @atscott). Thank you.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Mar 2, 2021
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 2, 2021
@AndrewKushnir
Copy link
Contributor

Merge assistance: this PR has received approvals from all the necessary groups, but PullApprove didn't pick up Jeremy's approval #40928 (review), so it indicates that the fw-security review is needed.

jelbourn
jelbourn approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try again

Reviewed-for: fw-security

@zarend zarend closed this in 97b88f3 Mar 3, 2021
zarend pushed a commit that referenced this pull request Mar 3, 2021
@crisbeto @zarend
fix(compiler): allow binding to autocomplete property on select and t…
20fb638 
…extarea elements (#40928)

Updates the schema to allow binding to the `autocomplete` property of a `textarea` or `select`.

Fixes #39490.

PR Close #40928
This was referenced Mar 8, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@jelbourn jelbourn jelbourn approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@kyliau kyliau Awaiting requested review from kyliau

@mhevery mhevery Awaiting requested review from mhevery

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Language service tags autocomplete for textarea and select as errors.
4 participants
@crisbeto @AndrewKushnir @atscott @jelbourn