perf(language-service): Skip Angular analysis when quick info request… #40956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed outside a template The Angular LS does not provide quick info when the given position is not inside a template. As an optimization, we can quickly look at the file and determine if we are at a position that is part of an Angular template. If not, we bail before asking the compiler for any more information. Note that the Angular LS _already_ provides no quick info when outside a template file, but currently asks the compiler to analyze the program before it determines that information.
atscott
added
the
area: language-service
kyliau
approved these changes
Feb 23, 2021
atscott
added a commit
that referenced
this pull request
Feb 23, 2021
…ed outside a template (#40956) The Angular LS does not provide quick info when the given position is not inside a template. As an optimization, we can quickly look at the file and determine if we are at a position that is part of an Angular template. If not, we bail before asking the compiler for any more information. Note that the Angular LS _already_ provides no quick info when outside a template file, but currently asks the compiler to analyze the program before it determines that information. PR Close #40956
This was referenced Mar 8, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed outside a template
The Angular LS does not provide quick info when the given position is not
inside a template. As an optimization, we can quickly look at the
file and determine if we are at a position that is part of an Angular
template. If not, we bail before asking the compiler for any more
information. Note that the Angular LS already provides no quick info
when outside a template file, but currently asks the compiler to analyze
the program before it determines that information.