-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localize): trim extracted equiv-text
values
#41180
Closed
petebacondarwin
wants to merge
1
commit into
angular:master
from
petebacondarwin:i18n-equiv-text-trimming-issue-41176
Closed
fix(localize): trim extracted equiv-text
values
#41180
petebacondarwin
wants to merge
1
commit into
angular:master
from
petebacondarwin:i18n-equiv-text-trimming-issue-41176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ViewEngine message extraction would trim the values of the `equiv-text` attributes. This commit aligns the Ivy extraction of these attributes. Fixes angular#41176
petebacondarwin
added
area: i18n
target: patch
This PR is targeted for the next patch release
engine: ivy
labels
Mar 11, 2021
petebacondarwin
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Mar 11, 2021
petebacondarwin
added
the
action: merge
The PR is ready for merge by the caretaker
label
Mar 11, 2021
AndrewKushnir
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
AndrewKushnir
removed
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Mar 11, 2021
This was referenced Mar 17, 2021
Merged
Closed
This was referenced Mar 18, 2021
Closed
Merged
Closed
Closed
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: i18n
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ViewEngine message extraction would trim the values
of the
equiv-text
attributes. This commit aligns the Ivyextraction of these attributes.
Fixes #41176