New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auxilliary Routes are not properly deactivated #41379
Comments
When we deactivate a child route, we deactivate its outlet as well as its children. We also need to remove this context from the parent `Map`. If we do not, the parent will hold on to a reference to this deactivated context and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
When we deactivate a child route, we deactivate its outlet as well as its children. We also need to remove this context from the parent `Map`. If we do not, the parent will hold on to a reference to this deactivated context and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
When we deactivate a child route, we deactivate its outlet as well as its children. We also need to remove this context from the parent `Map`. If we do not, the parent will hold on to a reference to this deactivated context and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
…ating route When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
…ating route When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
…ating route (#41381) When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes #41379 PR Close #41381
This bug fix broke our ionic app's navigation.... Is there a way to fix this issue without breaking our behavior as described here: ionic-team/ionic-framework#23230? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Auxilliary Routes are not properly deactivated
Affected Package
@angular/router
Description
Given an auxiliary route that is activated in a
<router-outlet>
,If we deactivate the outlet and then remove
<router-outlet>
and add it back to the DOM, the<router-outlet>
will be activated with the last active route and is now out of sync with the router.🔬 Minimal Reproduction
Starting here
<router-outlet>
is activated<router-outlet>
is deactivated<router-outlet>
is falsely activated again with the last active route(aux:1234)
and out of sync with the browser URLI expected the
<router-outlet>
to be deactivated🌍 Your Environment
Angular Version:
The text was updated successfully, but these errors were encountered: