fix(compiler): not generating update instructions for ng-template inside alternate namespaces #41669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide alternate namespaces We have a check that determines whether to generate property binding instructions for an `ng-template`. The check looks at whether the tag name is exactly `ng-template`, but the problem is that if the tag is placed in a non-HTML namespace (e.g. `svg`), the tag name will actually be `:namespace:ng-template` and the check will fail. These changes resolve the issue by looking at the tag name without the namespace. Fixes angular#41308.
crisbeto
added
action: review
AndrewKushnir
added
action: presubmit
AndrewKushnir
approved these changes
Apr 19, 2021
AndrewKushnir
removed
the
action: presubmit
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 20, 2021
…ide alternate namespaces (#41669) We have a check that determines whether to generate property binding instructions for an `ng-template`. The check looks at whether the tag name is exactly `ng-template`, but the problem is that if the tag is placed in a non-HTML namespace (e.g. `svg`), the tag name will actually be `:namespace:ng-template` and the check will fail. These changes resolve the issue by looking at the tag name without the namespace. Fixes #41308. PR Close #41669
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a check that determines whether to generate property binding instructions for an
ng-template. The check looks at whether the tag name is exactlyng-template, but the problem is that if the tag is placed in a non-HTML namespace (e.g.svg), the tag name will actually be:namespace:ng-templateand the check will fail.These changes resolve the issue by looking at the tag name without the namespace.
Fixes #41308.