Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): not generating update instructions for ng-template inside alternate namespaces #41669

Closed
wants to merge 1 commit into from
Closed

fix(compiler): not generating update instructions for ng-template inside alternate namespaces #41669

wants to merge 1 commit into from

Commits on Apr 17, 2021

  1. fix(compiler): not generating update instructions for ng-template ins… 

    …ide alternate namespaces

We have a check that determines whether to generate property binding instructions for an `ng-template`. The check looks at whether the tag name is exactly `ng-template`, but the problem is that if the tag is placed in a non-HTML namespace (e.g. `svg`), the tag name will actually be `:namespace:ng-template` and the check will fail.

These changes resolve the issue by looking at the tag name without the namespace.

Fixes angular#41308.
    @crisbeto
    crisbeto committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    08c1abc View commit details
    Browse the repository at this point in the history