Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular.io/guide/i18n live example does not work #41838

Closed
RudolfStarosta opened this issue Apr 27, 2021 · 13 comments
Closed

angular.io/guide/i18n live example does not work #41838

RudolfStarosta opened this issue Apr 27, 2021 · 13 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@RudolfStarosta
Copy link

RudolfStarosta commented Apr 27, 2021

馃摎 Docs or angular.io bug report

Description

When trying to start the live example on https://angular.io/guide/i18n which links to https://angular.io/generated/live-examples/i18n/stackblitz.html I get an 422 response.

馃敩 Minimal Reproduction

What's the affected URL?**

https://angular.io/guide/i18n

Reproduction Steps**

Click link live example (https://angular.io/generated/live-examples/i18n/stackblitz.html)

Expected vs Actual Behavior**

Stackblitz starts an shows source code and app generated from it

馃摲Screenshot

馃敟 Exception or Error




see comment


馃實 Your Environment

Browser info

Firefox 88.0 (64 bits)

Anything else relevant?

@RudolfStarosta
Copy link
Author

image

@ngbot ngbot bot added this to the needsTriage milestone Apr 27, 2021
@petebacondarwin
Copy link
Member

The error response gives us some indication:

{
  "error": "MISSING_PEERS",
  "data": {
    "@angular/compiler-cli": {
      "@angular/localize@11.2.11": "11.2.11"
    }
  }
}

I am not sure if this means that @angular/compiler-cli is missing or @angular/localize...

@petebacondarwin petebacondarwin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 27, 2021
@petebacondarwin petebacondarwin self-assigned this Apr 27, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Apr 27, 2021
@iRealNirmal
Copy link
Contributor

@petebacondarwin I think we should add link of live stackblitz link where translation example can be verified, if you want I can create stackblitz and help you update link for it.

@petebacondarwin
Copy link
Member

From @gkalpak

It is because we don't add the @angular/compiler-cli dependency (which is a devDependency) in our StackblitzBuilder:

// Add unit test packages from devDependencies for unit test examples
const devDependencies = packageJson.devDependencies;
['jasmine-core', 'jasmine-marbles'].forEach(dep => exampleDependencies[dep] = devDependencies[dep]);

And since @angular/localize has @angular/compiler-cli as a peerDependency, StackBlitz complains. (edited)

@petebacondarwin
Copy link
Member

@iRealNirmal : There is a link in the guide already. It points to this page that redirects to the StackBlitz.

@iRealNirmal
Copy link
Contributor

this is duplicate of #39563

@iRealNirmal
Copy link
Contributor

@petebacondarwin probably not but possible it's due to this incorrect version here?

@petebacondarwin
Copy link
Member

Indeed it is a duplicate. Since we have started the discussion here, I will close the other one.

@petebacondarwin
Copy link
Member

@iRealNirmal - that version for the CLI is actually correct. FW and CLI are out of sync by one patch version.
I believe the real reason is what @gkalpak wrote: #41838 (comment)

@iRealNirmal
Copy link
Contributor

ok thanks for heads up so @gkalpak is taking care of this change ? Also for patch version out of sync, do you think we should create ticket or we can ignore for now ?

@petebacondarwin
Copy link
Member

The CLI and FW are out of sync because one made an extra patch release to fix an urgent bug. It is no problem and doesn't need to be fixed.
Currently neither @gkalpak nor I are working on fixing this example, so if you want to give it a try, please go ahead.

@iRealNirmal
Copy link
Contributor

ok thanks I will try to work on this

iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 8, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 8, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 9, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 9, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 9, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of animation.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of i18n.

Closes angular#41838.
iRealNirmal added a commit to iRealNirmal/angular that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of i18n.

Closes angular#41838.
@alxhub alxhub closed this as completed in e071e3b May 10, 2021
alxhub pushed a commit that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of i18n.

Closes #41838.

PR Close #42001
alxhub pushed a commit that referenced this issue May 10, 2021
This commit fixes the broken stackblitz example of i18n.

Closes #41838.

PR Close #42001
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants