Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy URL shows page not found #46717

Closed
Arihant416 opened this issue Jul 6, 2022 · 6 comments
Closed

Ivy URL shows page not found #46717

Arihant416 opened this issue Jul 6, 2022 · 6 comments

Comments

@Arihant416
Copy link

Description

On updating angular version 11 to 12, the CLI shows a message

For additional information or if the build fails, please see Ivy Guide
The URL opens up to show page not found.

What is the affected URL?

https://angular.io/guide/ivy

Please provide the steps to reproduce the issue

You can reproduce this issue by pasting the URL on the browser directly or by redirecting from the CLI message.

Please provide the expected behavior vs the actual behavior you encountered

Expected behavior

  • There should have been some documentation about the Ivy compiler

Actual behavior

  • The URL redirects to a Page Not Found page.

Please provide a screenshot if possible

image

Please provide the exception or error you saw

No response

Is this a browser-specific issue? If so, please specify the device, browser, and version.

No response

@JoostK
Copy link
Member

JoostK commented Jul 6, 2022

This happens because the page has since been removed as obsolete in v14+, but older versions of Angular always link to just angular.io instead of a particular version; in this case that would be https://v12.angular.io/docs, which is still available.

We have an issue #44650 to reflect the version of Angular in links to documentation.

As for this specific problem, let's see what @gkalpak's thoughts are here.

@ngbot ngbot bot added this to the needsTriage milestone Jul 6, 2022
@gkalpak
Copy link
Member

gkalpak commented Jul 7, 2022

I see that the Ivy-related guides have been removed in #43860.
For those that we use in CLI/compiler error messages, we could create redirects to v12.angular.io, but I am not sure if it was a conscious choice not to do this. Maybe @dgp1130 remembers.

@dgp1130
Copy link
Contributor

dgp1130 commented Jul 7, 2022

I think we just never got around to linking errors messages to the current version of Angular. There's a lot of error messages with links like this and they would need to be updated for every major version, which can lead to a lot of churn.

One alternative approach to consider is to leave a "tombstone" in angular.io which tells users "This doc is deleted, but it previously existed in vX - link". Not sure how hard that is to do, but it's one solution to this problem.

I do agree that the ideal solution is for errors messages to link to their versions of the documentation. It's just something which hasn't been prioritized.

@gkalpak
Copy link
Member

gkalpak commented Jul 7, 2022

Thx for the insights, @dgp1130!

So, until version-specific links in errors are implemented, I think it makes sense to address the issue for the Ivy guide (and any other URLs that you might know are linked to from error messages but no longer exist on angular.io.

We could do the "tombstone" thing, but "tombstone" haven worked particularly well for the Angular team in the past 😛
What we've typically done in such cases is add a (server-side) redirect (for example, in this case, from angular.io/guide/ivy to v12.angular.io/guide/ivy). Any objections with that?

@dgp1130
Copy link
Contributor

dgp1130 commented Jul 7, 2022

Sounds reasonable to me. I could see some users getting confused about why they're getting redirected to older versions, but it's probably more important to get them to the content they want in the easiest way possible.

gkalpak added a commit to gkalpak/angular that referenced this issue Jul 13, 2022
Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see angular#43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes angular#46717
jessicajaniuk pushed a commit that referenced this issue Jul 13, 2022
Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see #43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes #46717

PR Close #46820
jessicajaniuk pushed a commit that referenced this issue Jul 13, 2022
Since Ivy is the default since v13, the Ivy guide (that used to live at
https://angular.io/guide/ivy) has been removed (see #43860). However,
there are certain error messages emitted by the CLI that still point to
it.

This commit address the problem by adding a redirect from
https://angular.io/guide/ivy to https://v12.angular.io/guide/ivy (which
is the last version that includes the guide).

Fixes #46717

PR Close #46820
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants