Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiler: calling super constructor #48

Closed
vsavkin opened this issue Oct 1, 2014 · 5 comments · May be fixed by codefresh-io/angular#4
Closed

transpiler: calling super constructor #48

vsavkin opened this issue Oct 1, 2014 · 5 comments · May be fixed by codefresh-io/angular#4
Assignees

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Oct 1, 2014

class Parent {
  constructor(arg:List){}
}

class Child extends Parent {
  constructor(arg:List){
    super(arg);
  }
}
@vicb
Copy link
Contributor

vicb commented Oct 1, 2014

@vsavkin what do you mean ?

I was looking for some info on how ctor are inherited in JS but haven't found yet (default ctor are not inherited in Dart). May be this issue relates to that ?

@vsavkin
Copy link
Contributor Author

vsavkin commented Oct 1, 2014

In Dart super is called in the initializer list. Currently, the transpiler leaves the super call in the constructor body, which is incorrect.

@vsavkin vsavkin self-assigned this Oct 1, 2014
@vicb
Copy link
Contributor

vicb commented Oct 1, 2014

I have this done a part of my pending PR (for const ctor only). May be you can re-assign it to me ?

@vsavkin vsavkin assigned vicb and unassigned vsavkin Oct 2, 2014
@vicb
Copy link
Contributor

vicb commented Oct 7, 2014

fixed in #45

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
dalejodc added a commit to dalejodc/angular that referenced this issue Aug 6, 2020
Translate CONTRIBUTING.md to spanish

Fix angular#48
dalejodc added a commit to dalejodc/angular that referenced this issue Aug 6, 2020
Translate CONTRIBUTING.md to spanish

Fix angular#48
dalejodc added a commit to dalejodc/angular that referenced this issue Aug 7, 2020
Translate CONTRIBUTING.md to spanish

Fix angular#48
dalejodc added a commit to dalejodc/angular that referenced this issue Aug 19, 2020
* docs: translate CONTRIBUTING.md to spanish

Translate CONTRIBUTING.md to spanish

Fix angular#48

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: Pato <11162114+devpato@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants