feat(transpiler): constructor and typed field semantics #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
force-pushed
the
1001-ctor
branch
2 times, most recently
from
d58b606
to
8f1058f
Compare
|
@vojtajina @mhevery @vsavkin This PR contains important architecture updates and it would be cool if it could be merged (or commented) quickly. |
vicb
force-pushed
the
1001-ctor
branch
4 times, most recently
from
364b97a
to
d0c0796
Compare
fixes angular#11 (constructor and typed field semantics) fixes angular#42 (Should we infer class property types from ctor args ?) fixes angular#17 (number (js) should map to num (dart))
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11 (constructor and typed field semantics)
fixes #42 (Should we infer class property types from ctor args ?)
fixes #17 (number (js) should map to num (dart))
I am also looking for a general feedback on this PR: there is quite some refactoring in this PR to conform more to the Traceur architecture. IMO it makes the code easier to maintain long-term, feedback is welcome.
Difference with the original ticket (#11):
@FINALis not implemented. All fields are declared final if the ctor is const. If the ctor is not const, no fields will be final. I see little value in this annotation at least for now.One thing that could be improved is that field must be initialized with a constant expression in Dart (for const ctor). This is not enforced right now but there is a TODO in the code. I think this could be implemented at a later point in time.