fix(core): Add an error state for ChangeDetectors that is set when bindings or lifecycle events throw exceptions and prevents further detection. #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
added
the
action: review
| @@ -423,7 +426,7 @@ export class ChangeDetectorJITGenerator { | |||
| /** @internal */ | |||
| _genOnInit(r: ProtoRecord): string { | |||
| var br = r.bindingRecord; | |||
| return `if (!throwOnChange && !${this._names.getAlreadyCheckedName()}) ${this._names.getDirectiveName(br.directiveRecord.directiveIndex)}.onInit();`; | |||
| return `if (!throwOnChange && ${this._names.getStateName()} == ${this.changeDetectorStateVarName}.NeverChecked) ${this._names.getDirectiveName(br.directiveRecord.directiveIndex)}.onInit();`; | |||
There was a problem hiding this comment.
Even though it does not matter in this case, but could you use === instead of ==?
vsavkin
removed
the
action: review
mhevery
added
the
action: cleanup
alxhub
force-pushed
the
cd-loop
branch
3 times, most recently
from
3ce47fe
to
4f698a4
Compare
…ndings or lifecycle events throw exceptions and prevents further detection. - Changes the `alreadyChecked` flag of AbstractChangeDetector to a new `state` flag. - Changes all checks of alreadyChecked to check that the state is NeverChecked. - Set state to Errored if an error is thrown during detection. - Skip change detection for a detector and its children when the state is Errored. - Add a test to validate this fixes issue angular#4323.
alxhub
added
action: merge
|
Merging PR #4953 on behalf of @alxhub to branch presubmit-alxhub-pr-4953. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alreadyCheckedflag of AbstractChangeDetector to a newstateflag.