Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ng control group validators #4954

Closed
wants to merge 2 commits into from

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Oct 27, 2015

Currently, it is not possible to add validators to control groups in the template. This limits template driven forms. This PR makes it possible.

<form some-form-validator>
  <div same-passwords>
    <input ng-control="password">
    <input ng-control="passwordConfirm">
  </div>
</form>

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 27, 2015
@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 27, 2015
@mary-poppins
Copy link

Merging PR #4954 on behalf of @mhevery to branch presubmit-mhevery-pr-4954.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mhevery mhevery assigned vsavkin and unassigned mhevery Oct 27, 2015
@vsavkin vsavkin closed this in 7580628 Oct 28, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants