Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch only partially patched. #50327

Closed
JeanMeche opened this issue May 16, 2023 · 1 comment
Closed

fetch only partially patched. #50327

JeanMeche opened this issue May 16, 2023 · 1 comment
Assignees
@JiaLiPassion
Labels
area: zones P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Milestone
Backlog

Comments

@JeanMeche
Copy link
Member

JeanMeche commented May 16, 2023 •
edited

Which @angular/* package(s) are the source of the bug?

zone.js

Is this a regression?

No

Description

While working on #50247, I believe we stumbled upon a patching issue with zone.js.

Zone.js only patches the first Promise returned by fetch. The NgZone become stable after and doesn't wait for 2nd Promise (text() or json() or body which returns a ReadableStream).

This is with the plugin zone-fetch-patch imported.

Stackblitz demo

cc @AndrewKushnir @alan-agius4
@ngbot ngbot bot added this to the needsTriage milestone May 16, 2023
@AndrewKushnir AndrewKushnir added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 16, 2023
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 16, 2023
@arturovt arturovt mentioned this issue Jun 10, 2023
Closed
arturovt added a commit to arturovt/angular that referenced this issue Jun 10, 2023
@arturovt
fix(zone.js): patch Response methods returned by fetch
ffbb112 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: angular#50327
@SebastianKohler SebastianKohler mentioned this issue Aug 10, 2023
Closed
arturovt added a commit to arturovt/angular that referenced this issue Nov 1, 2023
@arturovt
fix(zone.js): patch Response methods returned by fetch
67852ea 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: angular#50327
arturovt added a commit to arturovt/angular that referenced this issue Jan 26, 2024
@arturovt
fix(zone.js): patch Response methods returned by fetch
ba9574e 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: angular#50327
arturovt added a commit to arturovt/angular that referenced this issue Jan 30, 2024
@arturovt
fix(zone.js): patch Response methods returned by fetch
32022d9 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: angular#50327
jessicajaniuk pushed a commit that referenced this issue Jan 31, 2024
@arturovt @thePunderWoman
fix(zone.js): patch Response methods returned by fetch (#50653)
b69bf37 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: #50327

PR Close #50653
jessicajaniuk pushed a commit that referenced this issue Jan 31, 2024
@arturovt @thePunderWoman
fix(zone.js): patch Response methods returned by fetch (#50653)
260d3ed 
This commit updates the implementation of the `fetch` patch and additionally
patches `Response` methods which return promises. These are `arrayBuffer`, `blob`,
`formData`, `json` and `text`. This fixes the issue when zone becomes stable too early
before all of the `fetch` tasks complete. Given the following code:
```ts
appRef.isStable.subscribe(console.log);
fetch(...).then(response => response.json()).then(console.log);
```
The `isStable` observer would log `false, true, false, true`. This was happening because
`json()` was returning a native promise (and not a `ZoneAwarePromise`). But calling `then`
on the native promise returns a `ZoneAwarePromise` which notifies Angular about the task
being scheduled and forces to re-calculate the `isStable` state.

Issue: #50327

PR Close #50653
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JiaLiPassion JiaLiPassion

Labels
area: zones P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(zone.js): patch Response methods returned by fetch arturovt/angular
4 participants
@JeanMeche @JiaLiPassion @alan-agius4 @AndrewKushnir