Ambient Directives ♡ Dart Transformers #5129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
|
I think we should change the format by which ambient directives are declared. My suggestions:
I'll make comments in the PR for where I think these changes could be made. |
| @@ -18,6 +18,7 @@ TransformerOptions parseBarbackSettings(BarbackSettings settings) { | |||
| config, REFLECT_PROPERTIES_AS_ATTRIBUTES_OLD, | |||
| defaultValue: false); | |||
| } | |||
| var ambientDirectives = config[AMBIENT_DIRECTIVES]; | |||
There was a problem hiding this comment.
Use (and please rename) _readFileList to smooth over differences between single values & Lists
kegluneq
added
action: cleanup
vsavkin
force-pushed
the
ambient_directives_transformers
branch
from
b89edce
to
a3545b5
Compare
kegluneq
added
action: review
| @@ -99,6 +103,49 @@ class _CompileDataCreator { | |||
| return new CompileDataResults._(ngMeta, compileData); | |||
| } | |||
|
|
|||
| Future<List<CompileDirectiveMetadata>> _readAmbientDirectives() async { | |||
| if (ambientDirectives == null) return []; | |||
|
Do you have an objection to point 1 above? If so let's discuss, otherwise PTAL. |
kegluneq
added
action: cleanup
vsavkin
force-pushed
the
ambient_directives_transformers
branch
from
a3545b5
to
55c7df2
Compare
|
Changed the format to be "package:/library.dart#CORE_DIRECTIVES". |
| @@ -39,6 +40,10 @@ class TransformerOptions { | |||
| /// as attributes on DOM elements, which may aid in application debugging. | |||
| final bool reflectPropertiesAsAttributes; | |||
|
|
|||
| /// A set of directives that will be automatically passed-in to the template compiler | |||
| /// Format of an item in the list: angular2/lib/src/core/directives.dart:CORE_DIRECTIVES | |||
vsavkin
force-pushed
the
ambient_directives_transformers
branch
from
55c7df2
to
4cae870
Compare
| return newMetadata.flatten(token); | ||
|
|
||
| } else { | ||
| logger.warning('Could not resolve ${token} in ${uri}'); |
There was a problem hiding this comment.
Add a little more detail here:
logger.warning('Could not resolve ambient directive ${token} in ${uri}',
asset: metaAssetId);
4cae870
to
731e1ea
Compare
vsavkin
force-pushed
the
ambient_directives_transformers
branch
from
731e1ea
to
153114e
Compare
|
Merging PR #5129 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5129. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.