feat(core): extract platforms out of core #5219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
vsavkin
force-pushed
the
extract_platforms
branch
from
d89baae
to
5238bd9
Compare
| @@ -126,6 +127,8 @@ var NG_ALL = [ | |||
| 'Binding.toClass', | |||
| 'Binding.toFactory', | |||
| 'Binding.toValue', | |||
| 'BROWSER_APP_PROVIDERS:js', | |||
| 'BROWSER_PROVIDERS:js', | |||
IgorMinar
added
pr_state: LGTM
action: cleanup
vsavkin
force-pushed
the
extract_platforms
branch
from
5238bd9
to
e44c18f
Compare
|
Merging PR #5219 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5219. |
mary-poppins
removed
the
action: merge
vsavkin
force-pushed
the
extract_platforms
branch
from
e44c18f
to
0837ae4
Compare
mary-poppins
removed
the
action: merge
|
Merging PR #5219 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5219. |
vsavkin
force-pushed
the
extract_platforms
branch
from
0837ae4
to
645754f
Compare
|
Merging PR #5219 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5219. |
mary-poppins
removed
the
action: merge
Currently, core depends on the browser, which means that other platforms (e.g., NativeScript or webworker) cannot use the bootstrapping logic core provides. This PR extract makes bootstrapping logic in core completely platform-independent. The browser-specific code was moved to "angular2/platforms/browser". BREAKING CHANGE A few private helpers (e.g., platformCommon or applicationCommon) were removed or replaced with other helpers. Look at PLATFORM_COMMON_PROVIDERS, APPLICATION_COMMON_PROVIDERS, BROWSER_PROVIDERS, BROWSER_APP_PROVIDERS to see if they export the providers you need.
vsavkin
force-pushed
the
extract_platforms
branch
from
645754f
to
74cd2f4
Compare
|
Merging PR #5219 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5219. |
mary-poppins
removed
the
action: merge
vsavkin
added a commit
to vsavkin/angular
that referenced
this pull request
Nov 13, 2015
Currently, core depends on the browser, which means that other platforms (e.g., NativeScript or webworker) cannot use the bootstrapping logic core provides. This PR extract makes bootstrapping logic in core completely platform-independent. The browser-specific code was moved to "angular2/platforms/browser". BREAKING CHANGE A few private helpers (e.g., platformCommon or applicationCommon) were removed or replaced with other helpers. Look at PLATFORM_COMMON_PROVIDERS, APPLICATION_COMMON_PROVIDERS, BROWSER_PROVIDERS, BROWSER_APP_PROVIDERS to see if they export the providers you need. Closes angular#5219
vsavkin
added a commit
to vsavkin/angular
that referenced
this pull request
Nov 13, 2015
Currently, core depends on the browser, which means that other platforms (e.g., NativeScript or webworker) cannot use the bootstrapping logic core provides. This PR extract makes bootstrapping logic in core completely platform-independent. The browser-specific code was moved to "angular2/platforms/browser". BREAKING CHANGE A few private helpers (e.g., platformCommon or applicationCommon) were removed or replaced with other helpers. Look at PLATFORM_COMMON_PROVIDERS, APPLICATION_COMMON_PROVIDERS, BROWSER_PROVIDERS, BROWSER_APP_PROVIDERS to see if they export the providers you need. Closes angular#5219
vsavkin
added a commit
that referenced
this pull request
Nov 13, 2015
Currently, core depends on the browser, which means that other platforms (e.g., NativeScript or webworker) cannot use the bootstrapping logic core provides. This PR extract makes bootstrapping logic in core completely platform-independent. The browser-specific code was moved to "angular2/platforms/browser". BREAKING CHANGE A few private helpers (e.g., platformCommon or applicationCommon) were removed or replaced with other helpers. Look at PLATFORM_COMMON_PROVIDERS, APPLICATION_COMMON_PROVIDERS, BROWSER_PROVIDERS, BROWSER_APP_PROVIDERS to see if they export the providers you need. Closes #5219 Closes #5280
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, core depends on the browser, which means that other platforms (e.g., NativeScript or webworker) cannot use the bootstrapping logic core provides.
This PR extract makes bootstrapping logic in core completely platform-independent. The browser-specific code was moved to "angular2/platforms/browser".
BREAKING CHANGE
A few private helpers (e.g., platformCommon or applicationCommon) were removed or replaced with other helpers. Look at PLATFORM_COMMON_PROVIDERS, APPLICATION_COMMON_PROVIDERS, BROWSER_PROVIDERS, BROWSER_APP_PROVIDERS to see if they export the providers you need.