control-flow migration doesnt migrate code with *ngIf else directive

[naveedahmed1]

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

Yes

Description

I recently tried control flow migration schematics for my project using command ng generate @angular/core:control-flow although this time the command didnt throw any error but it didnt work either.

For eample for below teamplate:

<div *ngIf="list?.length>0;else noItemFound">
</div>
<ng-template #noItemFound>No item found</ng-template>

Below is the code that this migration produced:

 @if (list?.length>0;else noItemFound) {

}

<ng-template #noItemFound>No item found</ng-template>

Please provide a link to a minimal reproduction of the bug

For this I can add you to a private repo

Please provide the exception or error you saw

No exception was thrown but migrations didn't work

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 17.0.0-rc.3
Node: 18.18.2
Package Manager: npm 9.8.1
OS: win32 x64

Angular: 17.0.0-rc.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0-rc.3
@angular-devkit/build-angular   17.0.0-rc.3
@angular-devkit/core            17.0.0-rc.3
@angular-devkit/schematics      17.0.0-rc.3
@angular/cdk                    17.0.0-rc.1
@angular/cli                    17.0.0-rc.3
@angular/fire                   16.0.0
@angular/google-maps            17.0.0-rc.1
@angular/material               17.0.0-rc.1
@angular/pwa                    17.0.0-rc.3
@schematics/angular             17.0.0-rc.3
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.0

Anything else?

No response

[crisbeto]

It's because there's no space after the else. I've sent #52504 with a fix.

[naveedahmed1]

Thank you @crisbeto and @atscott :)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}