Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Dart bundle size #5312

Closed
kegluneq opened this issue Nov 16, 2015 · 5 comments
Closed

Track Dart bundle size #5312

kegluneq opened this issue Nov 16, 2015 · 5 comments
Assignees
Labels
effort2: days feature Issue that requests a new feature

Comments

@kegluneq
Copy link

See #5294 for pointers

@IgorMinar
Copy link
Contributor

  • we should replicate the internal hello world project
  • run that in a separate travis job
  • add analytics
  • consider implementing (in a follow up PR) a mechanism that would compare the current payload size with current master size and fail the build if more than X%. this will require storing the master payload size somewhere which complicates the matters. maybe we could use firebase for this?

@IgorMinar IgorMinar added this to the beta-01 milestone Nov 16, 2015
@yjbanov yjbanov assigned yjbanov and unassigned kegluneq Nov 16, 2015
@yjbanov
Copy link
Contributor

yjbanov commented Nov 16, 2015

+1 on @IgorMinar's proposals. I think it's reasonable to cap incremental increases. We still need the absolute <100kb gzipped and <300kb minified caps, as that's our SLA for internal customers, and also without them no matter what incremental percentage we choose it is still exponential.

@kegluneq kegluneq assigned kegluneq and unassigned yjbanov Nov 17, 2015
@mark1010
Copy link

#5311 Duplicate Output may be related. I see the same issue in the js build, and some level of duplication in the generated js, which may be impacting code size.

@mhevery mhevery added feature Issue that requests a new feature P2: required effort2: days labels Nov 19, 2015
@ochafik
Copy link
Contributor

ochafik commented Nov 19, 2015

Note: no need to store the build size anywhere, you could just checkout the master branch (or the previous commit if $TRAVIS_BRANCH == "master"), then just build all the playground examples, find the outputs and print their gzipped size into some json, do this once again for the branch's version and compare with a tiny node.js script (all this in a separate travis env).

kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 19, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
[skip ci]

Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
[skip ci]

Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
[skip ci]

Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 20, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 21, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 21, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 23, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 23, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 23, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 23, 2015
Move file size analytics code into a reusable module.

See angular#5312, angular#5314
kegluneq pushed a commit to kegluneq/angular that referenced this issue Nov 23, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See angular#5312, angular#5314
kegluneq pushed a commit that referenced this issue Nov 23, 2015
Move file size analytics code into a reusable module.

See #5312, #5314
kegluneq pushed a commit that referenced this issue Nov 23, 2015
Create gulp targets to build `hello_world` and check its gzipped size
against size constraints.

See #5312, #5314
@mhevery mhevery modified the milestones: beta.01, beta.02 Jan 25, 2016
@vicb vicb closed this as completed Jun 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort2: days feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

7 participants