Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adev] Missing angular.dev docs page for $localize #54388

Open
anisabboud opened this issue Feb 12, 2024 · 1 comment · May be fixed by #55345
Open

[adev] Missing angular.dev docs page for $localize #54388

anisabboud opened this issue Feb 12, 2024 · 1 comment · May be fixed by #55345
Labels
area: adev Angular.dev documentation area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@anisabboud
Copy link

anisabboud commented Feb 12, 2024

Describe the problem that you experienced

$localize links to two different locations/routes in the angular.dev docs, and both lead to 404:

  1. Go to https://angular.dev/guide/i18n/prepare#mark-text-in-component-code
    Click on $localize -> https://angular.dev/api/localize/init/$localize 404

  2. Go to https://angular.dev/api/localize/loadTranslations
    Click on $localize chip/tag -> https://angular.dev/api/localize/$localize also 404

Matching page on Angular.io: https://angular.io/api/localize/init/$localize

@anisabboud anisabboud changed the title [adev] Missing page for $localize [adev] Missing angular.dev docs page for $localize Feb 12, 2024
@jessicajaniuk jessicajaniuk added the area: adev Angular.dev documentation label Feb 13, 2024
@ngbot ngbot bot added this to the needsTriage milestone Feb 13, 2024
@bencodezen bencodezen added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Feb 13, 2024
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Feb 13, 2024
@bencodezen bencodezen added the area: docs Related to the documentation label Feb 13, 2024
@hansireit
Copy link
Contributor

I managed to add the entry to the list, but the page of the exported members is still not found. The members are even missing in the API manifest:
image

Probably because the members are exported by the barrel file from the angular-package and not from folder.

import {ɵ$localize as $localize, ....} from '@angular/localize'; // <-- Here

export {$localize, LocalizeFn, TranslateFn};

If the members are exported from the parent folder the docs are working:

import {$localize, LocalizeFn,TranslateFn} from '../src/localize';

export {$localize, LocalizeFn, TranslateFn};

Is anyone familiar with this and knows if this will break something?

JeanMeche added a commit to JeanMeche/angular that referenced this issue Apr 9, 2024
JeanMeche added a commit to JeanMeche/angular that referenced this issue Apr 14, 2024
…localize

$localize is privately exported but defined globaly and is part of the public API.

fixes angular#54388
JeanMeche added a commit to JeanMeche/angular that referenced this issue Apr 15, 2024
…localize

$localize is privately exported but defined globaly and is part of the public API.

fixes angular#54388
JeanMeche added a commit to JeanMeche/angular that referenced this issue Jun 10, 2024
JeanMeche added a commit to JeanMeche/angular that referenced this issue Jun 10, 2024
JeanMeche added a commit to JeanMeche/angular that referenced this issue Jun 10, 2024
JeanMeche added a commit to JeanMeche/angular that referenced this issue Jun 10, 2024
@JeanMeche JeanMeche linked a pull request Jun 10, 2024 that will close this issue
josephperrott pushed a commit to JeanMeche/angular that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: adev Angular.dev documentation area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
4 participants