Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control flow migration hanging on formatting in rare cases #54532

Closed
jessicajaniuk opened this issue Feb 20, 2024 · 1 comment
Closed

Control flow migration hanging on formatting in rare cases #54532

jessicajaniuk opened this issue Feb 20, 2024 · 1 comment
Assignees
@jessicajaniuk
Labels
area: migrations Issues related to `ng update` migrations core: control flow Issues related to the built-in control flow (@if, @for, @switch)
Milestone
needsTriage

Comments

@jessicajaniuk
Copy link
Contributor

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

No

Description

In a very rare case, the control flow migration will hang during formatting and never finish processing the remaining files.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

No response

Anything else?

No response
@jessicajaniuk jessicajaniuk added area: migrations Issues related to `ng update` migrations core: control flow Issues related to the built-in control flow (@if, @for, @switch) labels Feb 20, 2024
@ngbot ngbot bot added this to the needsTriage milestone Feb 20, 2024
@jessicajaniuk jessicajaniuk self-assigned this Feb 20, 2024
jessicajaniuk pushed a commit to jessicajaniuk/angular that referenced this issue Feb 20, 2024
@thePunderWoman
fix(migrations): Fix cf migration regular expression to include under…
e651c1c 
…scores

In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.

fixes: angular#54532
jessicajaniuk pushed a commit to jessicajaniuk/angular that referenced this issue Feb 20, 2024
@thePunderWoman
fix(migrations): Fix cf migration regular expression to include under…
4354700 
…scores

In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.

fixes: angular#54532
jessicajaniuk pushed a commit to jessicajaniuk/angular that referenced this issue Feb 20, 2024
@thePunderWoman
fix(migrations): Fix cf migration regular expression to include under…
577fa46 
…scores

In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.

fixes: angular#54532
alxhub pushed a commit that referenced this issue Feb 21, 2024
@thePunderWoman @alxhub
fix(migrations): Fix cf migration regular expression to include under…
bb57d34 
…scores (#54533)

In rare cases people may use an underscore in their component names, which was not accounted for in the formatting portion of the migration.

fixes: #54532

PR Close #54533
@alxhub alxhub closed this as completed in 42d3ddd Feb 21, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jessicajaniuk jessicajaniuk

Labels
area: migrations Issues related to `ng update` migrations core: control flow Issues related to the built-in control flow (@if, @for, @switch)
Projects
None yet
Milestone
needsTriage
Development

No branches or pull requests
1 participant
@jessicajaniuk