Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adev is broken on Firefox after xtermjs is loaded and table of contents item clicked #54894

Closed
lukasmatta opened this issue Mar 15, 2024 · 2 comments
Assignees

Comments

@lukasmatta
Copy link
Contributor

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

No

Description

How to reproduce:

  1. Go to https://angular.dev using Firefox
  2. Go to page that loads xtermjs (either https://angular.dev/playground or scroll down on the landing page)
  3. Go to Docs -> click on any item in the "On this page" section on the right
  4. Left sidebar is not visible anymore.

Repro video:
https://drive.google.com/file/d/12GHRIDE3GidLv_kASuid0cA0I9euEu2v/view

xtermjs seems to be inserting absolutely positioned elements that affect viewport width in Firefox.

image

Related to xtermjs/xterm.js#4805

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Firefox 123.0.1 on macOs 14.3.1

Anything else?

No response

@JeanMeche JeanMeche self-assigned this Mar 15, 2024
JeanMeche added a commit to JeanMeche/angular that referenced this issue Mar 15, 2024
With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894
JeanMeche added a commit to JeanMeche/angular that referenced this issue Mar 15, 2024
With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894
JeanMeche added a commit to JeanMeche/angular that referenced this issue Mar 15, 2024
With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894
@JeanMeche
Copy link
Member

Hi, we appreciate you took the time to investigate the issue.
#54897 will land the fix.

@alxhub alxhub closed this as completed in c3da797 Mar 15, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this issue Apr 6, 2024
…x. (angular#54897)

With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894

PR Close angular#54897
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants