Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): bump xterm to 5.4.0 to fix a layout issue on Firefox. #54897

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

With 5.4.0 xterm has migrated to scoped packages. We're now using @xterm/xterm.

Fixes #54894

@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 15, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 15, 2024
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Deployed adev-preview for 72aa89c to: https://ng-dev-previews-fw--pr-angular-angular-54897-adev-prev-gn7v32ej.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 15, 2024
@alxhub
Copy link
Member

alxhub commented Mar 15, 2024

This PR was merged into the repository by commit c3da797.

@alxhub alxhub closed this in c3da797 Mar 15, 2024
@JeanMeche JeanMeche deleted the fix/adev-xterm-firefox branch March 15, 2024 22:14
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
…x. (angular#54897)

With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`.

Fixes angular#54894

PR Close angular#54897
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adev is broken on Firefox after xtermjs is loaded and table of contents item clicked
3 participants