New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docs-infra): bump xterm to 5.4.0 to fix a layout issue on Firefox. #54897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cac65df
to
96758d6
Compare
With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`. Fixes angular#54894
96758d6
to
72aa89c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Deployed adev-preview for 72aa89c to: https://ng-dev-previews-fw--pr-angular-angular-54897-adev-prev-gn7v32ej.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This PR was merged into the repository by commit c3da797. |
…x. (angular#54897) With 5.4.0 `xterm` has migrated to scoped packages. We're now using `@xterm/xterm`. Fixes angular#54894 PR Close angular#54897
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With 5.4.0
xterm
has migrated to scoped packages. We're now using@xterm/xterm
.Fixes #54894