Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular.dev Playground is broken #55298

Closed
aluo123 opened this issue Apr 10, 2024 · 2 comments
Closed

Angular.dev Playground is broken #55298

aluo123 opened this issue Apr 10, 2024 · 2 comments
Assignees
@devversion
Labels
area: adev Angular.dev documentation state: has PR
Milestone
needsTriage

Comments

@aluo123
Copy link

aluo123 commented Apr 10, 2024

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

Yes

Description

When I navigate to https://angular.dev/playground the code does not populate in main.ts and game.html.

Screenshot 2024-04-10 at 3 56 11 PM

Please provide a link to a minimal reproduction of the bug

https://angular.dev/playground

Please provide the exception or error you saw

main-662YBD5Y.js:7 TypeError: Cannot read properties of undefined (reading 'length')
    at n.nextChild (chunk-2UIGY44H.js:10:36413)
    at Wn.enterChild (chunk-2UIGY44H.js:10:41793)
    at Wn.firstChild (chunk-2UIGY44H.js:10:42049)
    at Xh.startInner (chunk-2UIGY44H.js:10:53087)
    at Xh.advance (chunk-2UIGY44H.js:10:51004)
    at chunk-2UIGY44H.js:10:66458
    at n.withContext (chunk-2UIGY44H.js:10:67155)
    at n.work (chunk-2UIGY44H.js:10:66198)
    at init (chunk-2UIGY44H.js:10:69155)
    at n.create (chunk-2UIGY44H.js:4:17062)

Please provide the environment you discovered this bug in (run ng version)

No response

Anything else?

No response
@JeanMeche JeanMeche added the area: adev Angular.dev documentation label Apr 11, 2024
@ngbot ngbot bot added this to the needsTriage milestone Apr 11, 2024
@aluo123
Copy link
Author

aluo123 commented Apr 11, 2024

Looks like all the tutorials are broken, not just the playground

@JeanMeche JeanMeche mentioned this issue Apr 14, 2024
Closed
@devversion devversion self-assigned this Apr 15, 2024
devversion added a commit to devversion/angular that referenced this issue Apr 15, 2024
@devversion
build(docs-infra): fix playground lezer parsing
9f37525 
When we started fixing the version mismatch with local 1st-party
packages, we also re-routed all dependencies like `@lezer/javascript`
into `adev/node_modules`. This works fine, but results in a different
version mismatch because the codemirror dependencies may resolve the
Angular version from `/node_modules`- causing some subtle complex
runtime error.

This commmit fixes this by only re-routing dependenices that have
dependency on e.g. `@angular/core` into `adev/node_modules`.

Fixes angular#55298.
@devversion devversion mentioned this issue Apr 15, 2024
Closed
devversion added a commit to devversion/angular that referenced this issue Apr 15, 2024
@devversion
build(docs-infra): fix playground lezer parsing
40c0082 
When we started fixing the version mismatch with local 1st-party
packages, we also re-routed all dependencies like `@lezer/javascript`
into `adev/node_modules`. This works fine, but results in a different
version mismatch because the codemirror dependencies may resolve the
Angular version from `/node_modules`- causing some subtle complex
runtime error.

This commit fixes this by only re-routing dependencies that have
dependency on e.g. `@angular/core` into `adev/node_modules`.

Fixes angular#55298.
devversion added a commit to devversion/angular that referenced this issue Apr 15, 2024
@devversion
build(docs-infra): fix playground lezer parsing
b4bfa86 
When we started fixing the version mismatch with local 1st-party
packages, we also re-routed all dependencies like `@lezer/javascript`
into `adev/node_modules`. This works fine, but results in a different
version mismatch because the codemirror dependencies may resolve the
Angular version from `/node_modules`- causing some subtle complex
runtime error.

This commit fixes this by only re-routing dependencies that have
dependency on e.g. `@angular/core` into `adev/node_modules`.

Fixes angular#55298.
pkozlowski-opensource pushed a commit that referenced this issue Apr 15, 2024
@devversion @pkozlowski-opensource
build(docs-infra): fix playground lezer parsing (#55349)
9bf9864 
When we started fixing the version mismatch with local 1st-party
packages, we also re-routed all dependencies like `@lezer/javascript`
into `adev/node_modules`. This works fine, but results in a different
version mismatch because the codemirror dependencies may resolve the
Angular version from `/node_modules`- causing some subtle complex
runtime error.

This commit fixes this by only re-routing dependencies that have
dependency on e.g. `@angular/core` into `adev/node_modules`.

Fixes #55298.

PR Close #55349
iteriani pushed a commit to iteriani/angular that referenced this issue Apr 16, 2024
@devversion @iteriani
build(docs-infra): fix playground lezer parsing (angular#55349)
69e13a9 
When we started fixing the version mismatch with local 1st-party
packages, we also re-routed all dependencies like `@lezer/javascript`
into `adev/node_modules`. This works fine, but results in a different
version mismatch because the codemirror dependencies may resolve the
Angular version from `/node_modules`- causing some subtle complex
runtime error.

This commit fixes this by only re-routing dependencies that have
dependency on e.g. `@angular/core` into `adev/node_modules`.

Fixes angular#55298.

PR Close angular#55349
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
area: adev Angular.dev documentation state: has PR
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

build(docs-infra): fix playground lezer parsing devversion/angular
3 participants
@JeanMeche @devversion @aluo123