build(docs-infra): fix playground lezer parsing #55349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
fix-playground
branch
from
9f37525
to
40c0082
Compare
|
Deployed adev-preview for 6971d63 to: https://ng-dev-previews-fw--pr-angular-angular-55349-adev-prev-2aq4m6k6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
When we started fixing the version mismatch with local 1st-party packages, we also re-routed all dependencies like `@lezer/javascript` into `adev/node_modules`. This works fine, but results in a different version mismatch because the codemirror dependencies may resolve the Angular version from `/node_modules`- causing some subtle complex runtime error. This commit fixes this by only re-routing dependencies that have dependency on e.g. `@angular/core` into `adev/node_modules`. Fixes angular#55298.
follow up for angular-devkit which does not include peer deps in their depset
devversion
force-pushed
the
fix-playground
branch
from
bb00580
to
6971d63
Compare
JeanMeche
added
action: merge
|
@devversion One squash away and we're good here ! |
devversion
added
action: merge
|
@JeanMeche fixup commits are automatically squashed upon merge 😄 |
devversion
removed
action: cleanup
|
This PR was merged into the repository by commit 3471c41. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Apr 15, 2024
When we started fixing the version mismatch with local 1st-party packages, we also re-routed all dependencies like `@lezer/javascript` into `adev/node_modules`. This works fine, but results in a different version mismatch because the codemirror dependencies may resolve the Angular version from `/node_modules`- causing some subtle complex runtime error. This commit fixes this by only re-routing dependencies that have dependency on e.g. `@angular/core` into `adev/node_modules`. Fixes #55298. PR Close #55349
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 16, 2024
When we started fixing the version mismatch with local 1st-party packages, we also re-routed all dependencies like `@lezer/javascript` into `adev/node_modules`. This works fine, but results in a different version mismatch because the codemirror dependencies may resolve the Angular version from `/node_modules`- causing some subtle complex runtime error. This commit fixes this by only re-routing dependencies that have dependency on e.g. `@angular/core` into `adev/node_modules`. Fixes angular#55298. PR Close angular#55349
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started fixing the version mismatch with local 1st-party packages, we also re-routed all dependencies like
@lezer/javascriptintoadev/node_modules. This works fine, but results in a different version mismatch because the codemirror dependencies may resolve the Angular version from/node_modules- causing some subtle complex runtime error.This commit fixes this by only re-routing dependencies that have dependency on e.g.
@angular/coreintoadev/node_modules.Fixes #55298.