fix(migrations): resolve multiple structural issues with HttpClient migration #55557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igration Fixes several issues with the `HttpClient` migration that showed up after I tried updating the Material docs site to the latest v18 release. Includes: * The migration was assuming that all Angular decorators have at least one argument. This led to a null pointer error that broke the v18 update process when I was testing it. * The migration incorrectly reimplemented the detection of classes with Angular decorators. This can cause code to be migrated incorrectly and doesn't handle cases like import aliases. I've switched it to use the existing tooling for detecting decorated classes. * The migration was trying to migrate directives, even though they don't support the `imports` field. * The migration was detecting `TestBed.configureTestingModule` calls using a raw string match which is very fragile and can be broken by the user's formatting. * There were syntax errors in the unit tests. * There were type checking errors in the unit tests, for example none of them were importing the Angular decorators that they were migrating. There's more room for improvement, but this should resolve the most glaring issues without having to rewrite too much.
crisbeto
added
action: review
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 91b1f24. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 26, 2024
…igration (#55557) Fixes several issues with the `HttpClient` migration that showed up after I tried updating the Material docs site to the latest v18 release. Includes: * The migration was assuming that all Angular decorators have at least one argument. This led to a null pointer error that broke the v18 update process when I was testing it. * The migration incorrectly reimplemented the detection of classes with Angular decorators. This can cause code to be migrated incorrectly and doesn't handle cases like import aliases. I've switched it to use the existing tooling for detecting decorated classes. * The migration was trying to migrate directives, even though they don't support the `imports` field. * The migration was detecting `TestBed.configureTestingModule` calls using a raw string match which is very fragile and can be broken by the user's formatting. * There were syntax errors in the unit tests. * There were type checking errors in the unit tests, for example none of them were importing the Angular decorators that they were migrating. There's more room for improvement, but this should resolve the most glaring issues without having to rewrite too much. PR Close #55557
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues with the
HttpClientmigration that showed up after I tried updating the Material docs site to the latest v18 release. Includes:importsfield.TestBed.configureTestingModulecalls using a raw string match which is very fragile and can be broken by the user's formatting.There's more room for improvement, but this should resolve the most glaring issues without having to rewrite too much.