Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CLI command to update Material missing from 16/17/18 #56045

Closed
msmallest opened this issue May 23, 2024 · 5 comments
Closed

docs: CLI command to update Material missing from 16/17/18 #56045

msmallest opened this issue May 23, 2024 · 5 comments
Labels
area: adev Angular.dev documentation
Milestone

Comments

@msmallest
Copy link

Describe the problem that you experienced

For the updates to Angular 16 and 17 and 18, the https://angular.dev/update-guide guide does not give the CLI commands to update Material and run the schematics. This is despite checking "I use Angular Material" and clicking "Show me how to update!".

Enter the URL of the topic with the problem

https://angular.dev/update-guide

Describe what you were looking for in the documentation

Checking "I use Angular Material" and clicking "Show me how to update!" should show a command like ng update @angular/material@x where x is either 16 or 17 or 18, or some variation.

Describe the actions that led you to experience the problem

Using the upgrade guide. I have also seen a few people have issues from following the official update guide but manually bumping their Material versions because they did not see the Material CLI command.

Describe what you want to experience that would fix the problem

A checkbox with the respective ng update @angular/material@x for 16 and 17 and 18

Add a screenshot if that helps illustrate the problem

image

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

Consistent on Chrome and Firefox (desktop, MacOS)

I do not see any notion of it in `angular/adev/src/app/features/update
/recommendations.ts` for these affected versions https://github.com/angular/angular/blob/825023801baf8dbd0bd87b7ec46a65e869e08adb/adev/src/app/features/update/recommendations.ts#L2192, provided this is what I assume the updater reads from.
@JeanMeche
Copy link
Member

#56044 is up for v18.

@msmallest
Copy link
Author

Thank you

@JeanMeche
Copy link
Member

Also added 16/17. Thanks for the reminder.

@pkozlowski-opensource pkozlowski-opensource added the area: adev Angular.dev documentation label May 27, 2024
@ngbot ngbot bot added this to the needsTriage milestone May 27, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented May 27, 2024

@JeanMeche is this issue fixed now based on your comment ?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: adev Angular.dev documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants