alpha.48: tbody should not wrap tr in template

[todoubaba]

@Component({
  selector: 'my-cmp',
  template: `
  <table border>
    <thead>
      <th>col1</th>
      <th>col2</th>
    </thead>
    <tbody>
      <template ng-for #rx [ng-for-of]="values">
        <tr>
          <template ng-for #ry [ng-for-of]="rx">
            <td>{{ry}}</td>
          </template>
        </tr>
      </template>
    </tbody>
  </table>
  `
})
class MyCmp {
  values = [
    [11, 12],
    [21, 22]
  ];
}

http://plnkr.co/edit/ZXV6pLI44IqFQbIEX4zj?p=preview

[udos86]

Yep, recognized this one, too. Should not be a default behavior. It pollutes semantically correct table header markup and therefore quickly breaks anticipated rendering. Thanks for fixing!

[vicb]

Two way we can fix this:

• never explicitly add a <tbody>,
• add a <tbody> only if the <tr> has a parent (ie is not a fragment).

The first solution would produce consistent result whether rows are in the master template or added as fragment.

@tbosch what do you think ?

[tbosch]

Let's do it this way:
Never add an implicit parent when the parent element is a template element.

[cur3n4]

I am also experimenting the issue with tr in thead being wrapped with a tbdoy.

[cur3n4]

It doesn't happen in alpha 51. So all good

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}