Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Dart transformer tests are *probably* being skipped #5934

Closed
kegluneq opened this issue Dec 16, 2015 · 2 comments
Closed

Some Dart transformer tests are *probably* being skipped #5934

kegluneq opened this issue Dec 16, 2015 · 2 comments
Assignees
@kegluneq
Labels
type: bug/fix

Comments

@kegluneq
Copy link

I think a conflict between package:guinness and package:code_transformers is causing the tests registered via package:code_transformers wrapping methods to be skipped.

This is definitely happening locally, but due to limited output on Travis it is difficult to tell - will know soon.
@kegluneq kegluneq self-assigned this Dec 16, 2015
kegluneq pushed a commit to kegluneq/angular that referenced this issue Dec 16, 2015
test(dart/transform): Update e2e tests to run in a separate file
3a82d59 
A conflict between `package:guinness` and `package:test` is causing our
end-to-end Dart transformer tests to be skipped.

Run these end-to-end tests in a separate file to fix this.

Closes angular#5934
This was referenced Dec 16, 2015
Closed
Closed
kegluneq pushed a commit to kegluneq/angular that referenced this issue Dec 29, 2015
test(dart/transform): Update e2e tests to run in a separate file
7d03932 
A conflict between `package:guinness` and `package:test` is causing our
end-to-end Dart transformer tests to be skipped.

Run these end-to-end tests in a separate file to fix this.

Closes angular#5934
@kegluneq
Copy link
Author

These tests are not currently being skipped, but once we upgrade package:code_transformers, package:analyzer, and package:observe to their latest versions (which incorporate package:test), they will be.

Now working on upgrading those packages without losing tests - I'll close this since it is not an actual problem.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kegluneq kegluneq

Labels
type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(dart/transform): Update e2e tests to run in a separate file kegluneq/angular
1 participant
@kegluneq