-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zone is not defined in angular2@2.0.0-beta.0 #6007
Comments
@prolink007 all the files you are mentioning are generated from https://github.com/angular/angular/blob/master/modules/angular2/src/core/zone/ng_zone.ts So if there is a pb, it needs fixing there. |
I've noticed this problem when updating to beta 0, but it seems to only affect my app on dev mode. using prod mode as a workaround currently fixes the issue for me |
@pkozlowski-opensource Yeah, you're right. I was just posting the places where it failed. Here is the TS file that needs to be changed. C:\projects\TampaApps\NewsApp\node_modules\angular2\ts\src\core\zone\ng_zone.ts@352 |
Hi guys, I opened I PR last night with a potential fix #5995 |
@ciriarte I saw that earlier. Seems like it failed one of the tests. Added a link to the pull request in the issue. |
fix ng_zone.ts with check for long-stack-trace-zone if (enableLongStackTrace && zone.longStackTraceZone) {
errorHandling = StringMapWrapper.merge(zone.longStackTraceZone, {onError: function(e) { ngZone._notifyOnError(this, e); }});
} else { ... |
outdated |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Zone is not defined in the following files in
angular2@2.0.0-beta.0
.Changing the line of code from
StringMapWrapper.merge(Zone.longStackTraceZone, { onError: function (e) { ngZone._notifyOnError(this, e); } });
To
StringMapWrapper.merge(zone.longStackTraceZone, { onError: function (e) { ngZone._notifyOnError(this, e); } });
Fixes the issue. Notice the capitalization change. There is no
Zone
, but a parameterzone
.This is breaking builds. How long can we expect this to take to fix?
Link to pull request #5995
Thanks
The text was updated successfully, but these errors were encountered: