Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone is not defined in angular2@2.0.0-beta.0 #6007

Closed
prolink007 opened this issue Dec 18, 2015 · 8 comments
Closed

zone is not defined in angular2@2.0.0-beta.0 #6007

prolink007 opened this issue Dec 18, 2015 · 8 comments

Comments

@prolink007
Copy link

Zone is not defined in the following files in angular2@2.0.0-beta.0.

angular2\es6\dev\src\core\zone\ng_zone.js
angular2\es6\prod\src\core\zone\ng_zone.js
angular2\src\core\zone\ng_zone.js
angular2\ts\src\core\zone\ng_zone.js
angular2\bundles\angular2-all.umd.dev.js
angular2\bundles\angular2-all.umd.js
angular2\bundles\angular2.dev.js
angular2\bundles\angular2.js
angular2\bundles\web_worker\ui.dev.js
angular2\bundles\web_worker\worker.dev.js

Changing the line of code from
StringMapWrapper.merge(Zone.longStackTraceZone, { onError: function (e) { ngZone._notifyOnError(this, e); } });
To
StringMapWrapper.merge(zone.longStackTraceZone, { onError: function (e) { ngZone._notifyOnError(this, e); } });
Fixes the issue. Notice the capitalization change. There is no Zone, but a parameter zone.

This is breaking builds. How long can we expect this to take to fix?

Link to pull request #5995

Thanks

@pkozlowski-opensource
Copy link
Member

@prolink007 all the files you are mentioning are generated from https://github.com/angular/angular/blob/master/modules/angular2/src/core/zone/ng_zone.ts

So if there is a pb, it needs fixing there.

@nesheroj
Copy link

I've noticed this problem when updating to beta 0, but it seems to only affect my app on dev mode. using prod mode as a workaround currently fixes the issue for me

@prolink007
Copy link
Author

@pkozlowski-opensource Yeah, you're right. I was just posting the places where it failed.

Here is the TS file that needs to be changed.

C:\projects\TampaApps\NewsApp\node_modules\angular2\ts\src\core\zone\ng_zone.ts@352

@ciriarte
Copy link

Hi guys, I opened I PR last night with a potential fix #5995

@prolink007
Copy link
Author

@ciriarte I saw that earlier. Seems like it failed one of the tests. Added a link to the pull request in the issue.

@towa48
Copy link

towa48 commented Dec 20, 2015

fix ng_zone.ts with check for long-stack-trace-zone

if (enableLongStackTrace && zone.longStackTraceZone) {
      errorHandling = StringMapWrapper.merge(zone.longStackTraceZone, {onError: function(e) { ngZone._notifyOnError(this, e); }});
} else { ...

@vicb
Copy link
Contributor

vicb commented Jul 29, 2016

outdated

@vicb vicb closed this as completed Jul 29, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants