Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-zone) Use instance instead of type #5995

Closed
wants to merge 1 commit into from

Conversation

ciriarte
Copy link

I'm getting an undefined error on this line, it looks like we were meant to use the instance instead of the type identifier.

@ciriarte
Copy link
Author

@vsavkin My build failed, but it looks like it fails on deprecated ng-zone specs:

Chrome 39.0.2171 (Linux 0.0.0) NgZone long stack trace should produce long stack traces FAILED
    Expected 1 to be greater than 1.
        at /home/travis/build/angular/angular/dist/js/dev/es5/angular2/test/core/zone/ng_zone_DEPRECATED_spec.js:58:70 <- angular2/test/core/zone/ng_zone_DEPRECATED_spec.ts:85:41

This line was affecting our app in > alpha.53 up to beta.0

Please let me know if there's anyone else I should refer this issue to.

@vicb
Copy link
Contributor

vicb commented Dec 18, 2015

You should load the lts script when using long stack traces

@ciriarte
Copy link
Author

Makes sense. I'll close my PR before it creates more confusion.

@ciriarte ciriarte closed this Dec 18, 2015
@vicb
Copy link
Contributor

vicb commented Dec 18, 2015

#6008 has more details on what needs to be loaded (note that lts is included in angular2-polyfills.js)

@towa48
Copy link

towa48 commented Dec 20, 2015

check for long-stack-trace-zone.js

if (enableLongStackTrace && zone.longStackTraceZone) {
    errorHandling = collection_1.StringMapWrapper.merge(zone.longStackTraceZone, { onError: function (e) { ngZone._notifyOnError(this, e); } });
}

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants