-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings cleanup #6267
Typings cleanup #6267
Conversation
Something is fishy. In angular's fork we have "zone" (https://github.com/angular/DefinitelyTyped/blob/master/zone/zone.d.ts). The one on DefinitelyTyped has "zone.js" (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/zone.js/zone.js.d.ts#L6) This PR should have failed on Travis because the zone typings are missing.
Where did it find |
Hmm, I think it's because we give a SHA, and that can be resolved against a repo that doesn't have that in the tree anywhere: this works |
883c507
to
621e774
Compare
cc @vikerman |
45626ee
to
28a31f4
Compare
@@ -1,12 +1,12 @@ | |||
{ | |||
"version": "v4", | |||
"repo": "angular/DefinitelyTyped", | |||
"repo": "DefinitelyTyped/DefinitelyTyped", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more forks!
looks good, make lint pass |
5c8ae97
to
77ad163
Compare
Is this ready to merge? |
not ready to merge yet |
The upstream Jasmine typings don't define a type for the global object with Jasmine methods polluting it, so just use any. Also zone.js has a different name upstream.
3013149
to
03c0314
Compare
Reviewed in person with @mhevery |
cc @blakeembrey who helped with the design for this - thank you! |
This resolves Duplicate Identifier issues seen by many users, at the expense of more typings installation required in some cases. Removes the quickstart hack of placing all needed dependencies typings files in our distribution. Removes dependencies on nodejs from angular2/core. Fixes angular#5973 Fixes angular#5807 Fixes angular#6266 Angular now depends on es6-promise and es6-collections (and a handful of manual typings) rather than all of es6-shim. Fixes angular#5242 We previously had an undocumented breaking change, this is now documented in this commit. Fixes angular#6817 BREAKING CHANGE: Transitive typings are no longer included in the distribution. You may need to install typings in your project using http://github.com/typings/typings Users now must rely on getting typings from: - one of the peerDependencies, such as rxjs, which exposes typings via the moduleResolution=node mechanism. (see https://github.com/Microsoft/TypeScript/wiki/Typings-for-npm-packages) This happens automatically. - Using --target ES5 now requires manual installation of es6-promise and es6-collections typings. - Using some angular APIs may introduce a dependency on eg. nodejs or jasmine, and those typings need manual installation as well.
Merging PR #6267 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-6267. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We had our own fork due to some custom typings, but these have been pushed upstream.