Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DEVELOPER): JDK is needed for protractor to run selenium #6343

Conversation

alfonso-presa
Copy link
Contributor

Java's JDK is needed for selenium standalone server, right?

@zoechi
Copy link
Contributor

zoechi commented Jan 8, 2016

I haven't used selenium with Angular yet but I would assume this would do as well https://github.com/SeleniumHQ/docker-selenium

@alfonso-presa
Copy link
Contributor Author

Sorry for the lack of context. I meant that it was needed to run selenium standalone server during the angular's build process for e2e testing.

@jeffbcross
Copy link
Contributor

@alfonso-presa could you add a note to add context about this being a requirement for Selenium Standalone Server?

@jeffbcross jeffbcross added comp: build/pipeline action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 1, 2016
@alfonso-presa
Copy link
Contributor Author

Done!

@@ -47,6 +47,8 @@ following products on your development machine:

* [Bower](http://bower.io/).

* [Java Development Kit](http://www.oracle.com/technetwork/es/java/javase/downloads/index.html) wich is used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wich --> which

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants