Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouterLink overrides Ctrl+click or middle click for opening in new tab. #6806

Closed
oliverjanik opened this issue Feb 1, 2016 · 2 comments
Closed

RouterLink overrides Ctrl+click or middle click for opening in new tab. #6806

oliverjanik opened this issue Feb 1, 2016 · 2 comments

Comments

@oliverjanik
Copy link

RouterLink should under no circumstances disable middle button clicking or Ctrl+left clicking on elements.

Big no no from UX point of view. Why is it capturing click events at all?
@ericmartinezr
Copy link
Contributor

dup of #5908

@CaptainCodeman CaptainCodeman mentioned this issue Apr 14, 2016
Closed
@dloukadakis dloukadakis mentioned this issue May 24, 2016
Closed
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this issue Jun 21, 2016
@dloukadakis @KiaraGrouwstra
fix(router): openning links in new tab
1ac9dda 
Clicks on router-link should not prevent browser default action when
any mouse button other than left mouse button or ctrl/meta key is pressed.

router-link href should use location strategy external url.

Closes angular#5908
Closes angular#6806
Closes angular#7749
Closes angular#8806

Closes angular#8821
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router): openning links in new tab
2 participants
@oliverjanik @ericmartinezr