Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): fix url path for star segment in path recognizer #6976

Conversation

btford
Copy link
Contributor

@btford btford commented Feb 9, 2016

Supersedes #6514

Url path of star segments should equal the original path.

If you register the route /app/*location and invoke a url like /app/foo/bar
the PathRecognizer should return a url path equal to the invoked url.

Before this patch, everything after foo was ignored, which resulted in a
redirect to /app/foo which was probably not intended (at least in the angular
1.5 component router).

Url path of star segments should equal the original path.

If you register the route `/app/*location` and invoke a url like `/app/foo/bar`
the PathRecognizer should return a url path equal to the invoked url.

Before this patch, everything after `foo` was ignored, which resulted in a
redirect to `/app/foo` which was probably not intended (at least in the angular
1.5 component router).
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@btford btford added pr_state: LGTM action: merge The PR is ready for merge by the caretaker cla: yes and removed cla: no labels Feb 9, 2016
@mary-poppins
Copy link

Merging PR #6976 on behalf of @btford to branch presubmit-btford-pr-6976.

1 similar comment
@mary-poppins
Copy link

Merging PR #6976 on behalf of @btford to branch presubmit-btford-pr-6976.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants