-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular_1_router): Renamed transpiled require functions #7049
fix(angular_1_router): Renamed transpiled require functions #7049
Conversation
227c386
to
a0d6682
Compare
LGTM |
@@ -49,6 +49,7 @@ function main(modulesDirectory) { | |||
var IMPORT_RE = new RegExp("import \\{?([\\w\\n_, ]+)\\}? from '(.+)';?", 'g'); | |||
var INJECT_RE = new RegExp("@Inject\\(ROUTER_PRIMARY_COMPONENT\\)", 'g'); | |||
var IMJECTABLE_RE = new RegExp("@Injectable\\(\\)", 'g'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not part of your PR, but shouldn't that line say INJECTABLE_RE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
a0d6682
to
a522877
Compare
Got it @ericmartinezr |
a522877
to
e576c19
Compare
e576c19
to
f44017f
Compare
…les are transpiled The require function was causing failures when bundled using Browserify and SystemJS
f44017f
to
0ff0270
Compare
@petebacondarwin - Please add pr_state: LGTM if you think this is ready to be merged |
TAP Green |
Merging PR #7049 on behalf of @vikerman to branch presubmit-vikerman-pr-7049. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #6914
The require function was causing failures when using bundlers such as Browserify and SystemJS.
cc: @petebacondarwin