fix(angular_1_router): Renamed transpiled require functions #7049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
force-pushed
the
router1-build-require
branch
from
227c386 to
a0d6682
Compare
|
LGTM |
| @@ -49,6 +49,7 @@ function main(modulesDirectory) { | |||
| var IMPORT_RE = new RegExp("import \\{?([\\w\\n_, ]+)\\}? from '(.+)';?", 'g'); | |||
| var INJECT_RE = new RegExp("@Inject\\(ROUTER_PRIMARY_COMPONENT\\)", 'g'); | |||
| var IMJECTABLE_RE = new RegExp("@Injectable\\(\\)", 'g'); | |||
There was a problem hiding this comment.
I know this is not part of your PR, but shouldn't that line say INJECTABLE_RE?
brandonroberts
force-pushed
the
router1-build-require
branch
from
a0d6682 to
a522877
Compare
|
Got it @ericmartinezr |
brandonroberts
force-pushed
the
router1-build-require
branch
from
a522877 to
e576c19
Compare
petebacondarwin
added
the
action: merge
brandonroberts
force-pushed
the
router1-build-require
branch
from
e576c19 to
f44017f
Compare
…les are transpiled The require function was causing failures when bundled using Browserify and SystemJS
brandonroberts
force-pushed
the
router1-build-require
branch
from
f44017f to
0ff0270
Compare
|
@petebacondarwin - Please add pr_state: LGTM if you think this is ready to be merged |
|
TAP Green |
|
Merging PR #7049 on behalf of @vikerman to branch presubmit-vikerman-pr-7049. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6914
The require function was causing failures when using bundlers such as Browserify and SystemJS.
cc: @petebacondarwin