fix(es6): stringify using an opaque ID rather than toString #7825
Conversation
alexeagle
force-pushed
the
stringify
branch
2 times, most recently
from
4f35086
to
dfc6c33
Compare
| @@ -175,6 +177,15 @@ export function stringify(token): string { | |||
| } | |||
|
|
|||
| var res = token.toString(); | |||
| if (res.indexOf("(") >= 0) { | |||
| let idx = ObjectReference.indexOf(token); | |||
There was a problem hiding this comment.
This gets slower over time and contains a memory leak.
Better: Create a facade around a WeakMap in JS and Expando in Dart (see https://api.dartlang.org/stable/1.15.0/dart-core/Expando-class.html)
There was a problem hiding this comment.
Also, I don't think this is the right place to do this. Rather, we should change our codegen to check for this and keep a local map of the produced symbols. My current PR is already doing this....
There was a problem hiding this comment.
Could you paste the code that breaks? I.e. so that we can find and fix the place where we generate the code, and don't have to do this in this global helper, which might be used for other things than codegen?
There was a problem hiding this comment.
Moved this logic into runtime_metadata.ts and switched to Map to store the anonymous function objects.
alexeagle
force-pushed
the
stringify
branch
2 times, most recently
from
10c0e31
to
d60e838
Compare
| @@ -33,6 +33,25 @@ export class RuntimeMetadataResolver { | |||
| @Optional() @Inject(PLATFORM_DIRECTIVES) private _platformDirectives: Type[], | |||
| @Optional() @Inject(PLATFORM_PIPES) private _platformPipes: Type[]) {} | |||
|
|
|||
| private anonymousTypes = new Map<Object, number>(); | |||
There was a problem hiding this comment.
Move up to the other field declarations, before the constructor.
Use _ prefix (so the field is private also in Dart)
tbosch
added
pr_state: LGTM
action: cleanup
…ens.
Using toString results in 'function (_arg1, arg2) {' when using closure compiler for 6-to-5.
alexeagle
added
action: merge
|
Merging PR #7825 on behalf of @kara to branch presubmit-kara-pr-7825. |
|
That's the same fix that's necessary for #6501 |
…ens.
Using toString results in 'function (_arg1, arg2) {' when using closure compiler for 6-to-5.
Closes angular#7825
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Using toString results in 'function (_arg1, arg2) {' when using closure compiler for 6-to-5.