Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slashes are stripped from route URLs, creating two history entries and breaking the back button in the process #7829

Closed
mgol opened this issue Mar 30, 2016 · 1 comment

Comments

@mgol
Copy link
Member

mgol commented Mar 30, 2016

Steps to reproduce and a minimal demo of the problem

  1. Open http://plnkr.co/edit/YSXkieNgWu9Ug8wVBx5e?p=preview
  2. Click "Launch the preview in a separate window".
  3. Look at the URL bar while clicking on the link in the preview

Current behavior

The path changes to /#/list/ and then immediately to /#/list, creating two history entries and breaking the back button in the process.

Expected/desired behavior

The redirection shouldn't occur. The trailing slash shouldn't have been stripped.

Other information

Currently the only workaround I know is to create routes not ending with a slash; the problem doesn't exist then.

reneweb pushed a commit to reneweb/angular that referenced this issue Apr 4, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829
reneweb pushed a commit to reneweb/angular that referenced this issue Apr 6, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829
reneweb pushed a commit to reneweb/angular that referenced this issue Apr 7, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829
reneweb pushed a commit to reneweb/angular that referenced this issue Apr 7, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829
reneweb pushed a commit to reneweb/angular that referenced this issue Apr 8, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this issue Jun 10, 2016
…ormalized path

Make sure the same path is not added multiple times to the history.
It is replacing the state, instead of skipping it completely,
because the current path in the browser might not be normalized,
while the given one is normalized.

Closes angular#7829

Closes angular#7897
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants