Make compiler_cli tests work again #8429
Conversation
| @@ -5,7 +5,7 @@ | |||
| "lib": ["es6", "dom"], | |||
There was a problem hiding this comment.
I don't care for the renames of tsconfig.json. Why are you doing this? It works fine in editors I've tried. This makes it harder to configure my editor.
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
if you move the bin, you need to move the main and typings also, right?
There was a problem hiding this comment.
I don't think so. index.ts is still on the main level.
tbosch
force-pushed
the
compiler_cli
branch
6 times, most recently
from
ad96404
to
9ac81fb
Compare
tbosch
force-pushed
the
compiler_cli
branch
4 times, most recently
from
4c6bc69
to
b3ac73b
Compare
| // For TypeScript 1.8, we have to lay out generated files | ||
| // in the same source directory with your code. | ||
| "genDir": ".", | ||
| "legacyPackageLayout": false |
There was a problem hiding this comment.
may as well remove (false is the default and maybe we should just drop this option - no one should be using ngc with a beta version)
…roperly into the build This also does no more depend on a version on npm for the compiler_cli. Also runs the tests for tools/metadata
|
lgtm |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.