New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compiler_cli tests work again #8429
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export {CodeGenerator} from './src/codegen'; | ||
export {NodeReflectorHost} from './src/reflector_host'; | ||
export {TsickleHost, MetadataWriterHost} from './src/compiler_host'; |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
modules/@angular/compiler_cli/integrationtest/tsconfig.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"angularCompilerOptions": { | ||
// For TypeScript 1.8, we have to lay out generated files | ||
// in the same source directory with your code. | ||
"genDir": ".", | ||
"legacyPackageLayout": false | ||
}, | ||
|
||
"compilerOptions": { | ||
"target": "es5", | ||
"experimentalDecorators": true, | ||
"noImplicitAny": false, | ||
"moduleResolution": "node", | ||
"outDir": "../../../../dist/all/@angular/compiler_cli/integrationtest", | ||
"rootDir": "", | ||
"declaration": true, | ||
|
||
"baseUrl": ".", | ||
"paths": { | ||
"@angular/*": ["../../../../dist/all/@angular/*"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/// <reference path="../../typings/es6-collections/es6-collections.d.ts" /> | ||
/// <reference path="../../typings/es6-promise/es6-promise.d.ts" /> | ||
/// <reference path="../../typings/node/node.d.ts" /> | ||
/// <reference path="../../typings/jasmine/jasmine.d.ts" /> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
"main": "index.js", | ||
"typings": "index.d.ts", | ||
"bin": { | ||
"ngc": "./main.js" | ||
"ngc": "./src/main.js" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this correct? why is bin pointing under a different path than main? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's two different files... Nobody should use |
||
}, | ||
"dependencies": { | ||
"ts-metadata-collector": "^0.1.0", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import {__compiler_private__ as _c} from '@angular/compiler'; | ||
|
||
export var AssetUrl: typeof _c.AssetUrl = _c.AssetUrl; | ||
export type AssetUrl = _c.AssetUrl; | ||
|
||
export var ImportGenerator: typeof _c.ImportGenerator = _c.ImportGenerator; | ||
export type ImportGenerator = _c.ImportGenerator; | ||
|
||
export type CompileMetadataResolver = _c.CompileMetadataResolver; | ||
export var CompileMetadataResolver: typeof _c.CompileMetadataResolver = _c.CompileMetadataResolver; | ||
|
||
export type HtmlParser = _c.HtmlParser; | ||
export var HtmlParser: typeof _c.HtmlParser = _c.HtmlParser; | ||
|
||
export type DirectiveNormalizer = _c.DirectiveNormalizer; | ||
export var DirectiveNormalizer: typeof _c.DirectiveNormalizer = _c.DirectiveNormalizer; | ||
|
||
export type Lexer = _c.Lexer; | ||
export var Lexer: typeof _c.Lexer = _c.Lexer; | ||
|
||
export type Parser = _c.Parser; | ||
export var Parser: typeof _c.Parser = _c.Parser; | ||
|
||
export type TemplateParser = _c.TemplateParser; | ||
export var TemplateParser: typeof _c.TemplateParser = _c.TemplateParser; | ||
|
||
export type DomElementSchemaRegistry = _c.DomElementSchemaRegistry; | ||
export var DomElementSchemaRegistry: typeof _c.DomElementSchemaRegistry = _c.DomElementSchemaRegistry; | ||
|
||
export type StyleCompiler = _c.StyleCompiler; | ||
export var StyleCompiler: typeof _c.StyleCompiler = _c.StyleCompiler; | ||
|
||
export type ViewCompiler = _c.ViewCompiler; | ||
export var ViewCompiler: typeof _c.ViewCompiler = _c.ViewCompiler; | ||
|
||
export type TypeScriptEmitter = _c.TypeScriptEmitter; | ||
export var TypeScriptEmitter: typeof _c.TypeScriptEmitter = _c.TypeScriptEmitter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import {__core_private__ as r, __core_private_types__ as t} from '@angular/core'; | ||
|
||
export type ReflectorReader = t.ReflectorReader; | ||
export var ReflectorReader: typeof t.ReflectorReader = r.ReflectorReader; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may as well remove (false is the default and maybe we should just drop this option - no one should be using ngc with a beta version)