[Core] Could APP_INITIALIZER depend on ApplicationRef ?

[vicb]

Right now APP_INITIALIZERs can not have a dependency on ApplicationRef because the initializers are executed in ApplicationRef_ ctor.

Would there be a way to allow such a dep ? (ie execute the initializers after the ApplicationRef_ is constructed ?)

/cc @tbosch @vsavkin

(the use case is APP_INITIALIZER -> Router -> AppRef)

[PatrickJS]

@vicb can you take a look at #9110 that allows for this

[tbosch]

We could change this.
However, there is a more general problem to solve: If the router should be provided at a component (and not to the bootstrap call), app initializers won't run any more. A possible solution would be to support Provider.eager...

[tbosch]

Reviewed #9110 and added some comments. But it is the right change for now, as adding eager providers would be a bigger change...

[PatrickJS]

it seems like we just need more lifecycle hooks for platform/application (sometime like: beforebootstrap, afterbootstrap, beforetick, aftertick)

[simperreault]

Just to point out an issue created by this one. When we try to navigate in the OnInit function of the RootComponent, the navigate event is cancelled. This happen because the method initialNavigation() on Router is called after the initialization of the RootComponent and cancelling the current ongoing navigation event. This is caused by the setTimeout() here https://github.com/angular/angular/blob/master/modules/@angular/router/src/common_router_providers.ts#L54-L61.

It should be fix with this issue with the increase of lifecycle hooks (or whatever strategy you guys intent to do)

[lacolaco]

After introducing AppModule, we maybe want something lifecycle method like ngModuleLoaded in a module class.

[tbosch]

Modules are eager, i.e. their constructor can be used as an app initializer
as well.
On Wed, Jul 6, 2016 at 4:58 PM Suguru Inatomi notifications@github.com
wrote:

After introducing AppModule, we maybe want something lifecycle method
like ngModuleLoaded in a module class.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#9101 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAqKf4AcDRCp9JIz-JQWiJialblYyJFiks5qTEE-gaJpZM4IxfHU
.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}