Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] ICU plural format - support # and offset #9117

Closed
vicb opened this issue Jun 9, 2016 · 5 comments
Closed

[i18n] ICU plural format - support # and offset #9117

vicb opened this issue Jun 9, 2016 · 5 comments
Labels
area: i18n effort1: hours feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Milestone

Comments

@vicb
Copy link
Contributor

vicb commented Jun 9, 2016

We currently do not support offset nor #

ICU:

    "{num_guests, plural, offset:1 "
      "=0 {{host} does not give a party.}"
      "=1 {{host} invites {guest} to her party.}"
      "=2 {{host} invites {guest} and one other person to her party.}"
      "other {{host} invites {guest} and # other people to her party.}}}"

While this is not strictly required because we can use angular expression, it would be nicer for translators.

For # we need:

@vicb vicb added feature Issue that requests a new feature effort1: hours area: i18n labels Jun 9, 2016
@vicb vicb mentioned this issue Jun 9, 2016
21 tasks
@vicb vicb changed the title [i18n] ICU plural format [i18n] ICU plural format - support # and offset Aug 4, 2016
@ocombe ocombe mentioned this issue May 2, 2017
20 tasks
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@thekip
Copy link

thekip commented Feb 4, 2019

Moreover current interpolation syntax in ICU breaks support of ICU in most of the translation tools.

For example ICU from docs:

{VAR_PLURAL, plural, =0 {just now} =1 {one minute ago} other {<x id="INTERPOLATION" equiv-text="{{minutes}}"/> minutes ago} }

Put it to commonly used ICU validator: https://format-message.github.io/icu-message-format-for-translators/editor.html

ICU supprot tools usually don't understand < symbol inside ICU, and if understand they become completele broken when they rich }} inside interpolation tag.

This forces users to search for tool wich is Angular-aware which greatly reduces the choice (i actually didn't find any) or just give up to full ICU syntax and edit it as simple string.

@ValentinFunk
Copy link

This would be incredibly nice to have, currently translation tool support for angular is not very good and this would help a lot. It's also a lot nicer to write and read in templates.

Additionally when you look at ICU guides they very often mention the # shortcut and it was a bit suprising to me that this didn't work in Angular.

@petebacondarwin petebacondarwin modified the milestones: Backlog, i18n-ideas Feb 12, 2020
javiermarinros added a commit to ideatic/l10n that referenced this issue Nov 2, 2020
@angular-robot
Copy link
Contributor

angular-robot bot commented May 21, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 10, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors label Jun 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: i18n effort1: hours feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

5 participants