Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api review and cleanup @angular/platform-server #9237

Closed
3 tasks
IgorMinar opened this issue Jun 16, 2016 · 2 comments
Closed
3 tasks

api review and cleanup @angular/platform-server #9237

IgorMinar opened this issue Jun 16, 2016 · 2 comments
Assignees
@mhevery
Milestone
2.0.0-rc.4

Comments

@IgorMinar
Copy link
Contributor

due to regressions in rc2 release the following commits got reverted yesterday: 80deac5 80deac5

these changes are desirable and we need to correct them and bring them back to master.

  • correct and unrevert the commits above
  • review the remaining public api surface
  • add stability markers
@IgorMinar IgorMinar added this to the 2.0.0-rc.3 milestone Jun 16, 2016
@mhevery mhevery self-assigned this Jun 17, 2016
@mhevery
Copy link
Contributor

mhevery commented Jun 17, 2016

#9205

mhevery added a commit to mhevery/angular that referenced this issue Jun 17, 2016
@mhevery
fix: cleanup public api of platform-server
c3ba64f 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
mhevery added a commit to mhevery/angular that referenced this issue Jun 17, 2016
@mhevery
fix: cleanup public api of platform-server
16787e3 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
mhevery added a commit to mhevery/angular that referenced this issue Jun 17, 2016
@mhevery
fix: cleanup public api of platform-server
5d2e1ad 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
mhevery added a commit to mhevery/angular that referenced this issue Jun 19, 2016
@mhevery
fix: cleanup public api of platform-server
a896f20 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
mhevery added a commit to mhevery/angular that referenced this issue Jun 19, 2016
@mhevery
fix: cleanup public api of platform-server
d5240dc 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
mhevery added a commit to mhevery/angular that referenced this issue Jun 19, 2016
@mhevery
fix: cleanup public api of platform-server
b5302bf 
BREAKING CHANGE: Parse5Adapter is no longer exported as public API, use serverBootstrap()

Parse5Adapter is an implementation detail not a public API

Closes angular#9237
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhevery mhevery

Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.4
Development

No branches or pull requests
2 participants
@mhevery @IgorMinar