Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StaticReflector reports 'call not supported' if a class uses a custom decorator. #9265

Closed
chuckjaz opened this issue Jun 16, 2016 · 2 comments · Fixed by #9266
Closed

StaticReflector reports 'call not supported' if a class uses a custom decorator. #9265

chuckjaz opened this issue Jun 16, 2016 · 2 comments · Fixed by #9266
Assignees
@chuckjaz
Labels
area: core Issues related to the framework runtime type: bug/fix
Milestone
2.0.0-rc.4

Comments

@chuckjaz
Copy link
Contributor

chuckjaz commented Jun 16, 2016 •
edited by IgorMinar
Loading

  • I'm submitting a ...
[x] bug report

Current behavior

When getting metadata statically for a type such as:

export class Foo {
  @CustomDecorator() get foo(): string { return ''; }
}

the static reflector reports Unsupported function call ....

Expected/desired behavior

The custom decorator should be ignored.
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 16, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
72d4167 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
@chuckjaz chuckjaz mentioned this issue Jun 16, 2016
Merged
12 tasks
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 16, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
481c7f4 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
@vicb vicb added type: bug/fix area: core Issues related to the framework runtime labels Jun 16, 2016
@vicb
Copy link
Contributor

vicb commented Jun 16, 2016

@chuckjaz could you please update the milestone when the fix is expected ? Thanks

@chuckjaz chuckjaz added this to the 2.0.0-rc.3 milestone Jun 16, 2016
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 16, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
18dabb7 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 16, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
b4a79a0 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
@chuckjaz chuckjaz self-assigned this Jun 16, 2016
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 17, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
447855c 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 17, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
cfcdc84 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jun 17, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators.
b216d15 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes angular#9182
Fixes angular#9265
chuckjaz added a commit that referenced this issue Jun 17, 2016
@chuckjaz
fix(compiler): StaticReflector ignores unregistered decorators. (#9266)
791153c 
Also modified static reflector to allow writing tests in using
the .ts and using the MetadataCollector.

Also made MetadataCollector be able to use SourceFiles that have
not been bound (that is, don't have the parent property set).

Fixes #9182
Fixes #9265
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chuckjaz chuckjaz

Labels
area: core Issues related to the framework runtime type: bug/fix
Projects
None yet
Milestone
2.0.0-rc.4
Development

Successfully merging a pull request may close this issue.

fix(compiler): StaticReflector ignores unregistered decorators. chuckjaz/angular
2 participants
@vicb @chuckjaz