Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[animation]: RC2 Animation does not support transitions with boolean states #9396

Closed
coryshaw1 opened this issue Jun 21, 2016 · 4 comments
Closed
Assignees
Labels
area: animations feature Issue that requests a new feature

Comments

@coryshaw1
Copy link

coryshaw1 commented Jun 21, 2016

Currently for any animations to work with booleans passed in as the state, you need to pass through the boolean's string form like so:

@yourAnimation="yourBoolean ? 'true' : 'false'"

I feel that boolean states should be supported with simply passing in the boolean itself:

@yourAnimation="yourBoolean"

Here's a working plunker of the bug: http://plnkr.co/edit/ajeC3SJ6LvKUivzQ8kW0

Edit: Upon further investigation, I should be saying boolean transitions, not states. Booleans don't match with any transitions that have 'true' or 'false' in it (Ex: 'true <=> false', 'true => *', 'void => true', etc.)

@coryshaw1 coryshaw1 changed the title [animation]: RC2 Animation does not support boolean states [animation]: RC2 Animation does not support boolean states transitions Jun 21, 2016
@coryshaw1 coryshaw1 changed the title [animation]: RC2 Animation does not support boolean states transitions [animation]: RC2 Animation does not support transitions with boolean states Jun 21, 2016
@vicb vicb added feature Issue that requests a new feature area: animations labels Jun 21, 2016
@matsko
Copy link
Contributor

matsko commented Jul 26, 2016

Maybe we should toString() values of a boolean type to true / false? How does that sound @robertmesserle @ThomasBurleson?

@ThomasBurleson
Copy link

@matsko - perhaps any (stringVal !== "true" || stringVal !== "1") === false?

@robertmesserle
Copy link

I think I like what @matsko suggested - convert to string and treat boolean values as "true" | "false"

matsko added a commit to matsko/angular that referenced this issue Sep 19, 2017
matsko added a commit to matsko/angular that referenced this issue Oct 5, 2017
matsko added a commit to matsko/angular that referenced this issue Oct 5, 2017
chuckjaz pushed a commit that referenced this issue Oct 9, 2017
matsko added a commit to matsko/angular that referenced this issue Oct 11, 2017
matsko added a commit to matsko/angular that referenced this issue Oct 12, 2017
tbosch pushed a commit that referenced this issue Oct 13, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: animations feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants