fix(testing): Add platform directives to the shim that keeps setBaseTestProviders running #10154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estProviders running Due to angular@daa9da4, tests using the setBaseTestProviders stopped working with ambient directives such as `ngIf`. Add them back in to keep the shim working.
juliemr
added
the
area: testing
|
cc @tbosch Tobias, could you take a look at this one? Is this a reasonable way to keep the shim working? |
juliemr
added
the
action: review
tbosch
added
pr_state: LGTM
and removed
action: review
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to daa9da4,
tests using the setBaseTestProviders stopped working with ambient directives such as
ngIf. Add them back in to keep the shim working.